Skip to content

Upgrade StyleCopAnalyzers to v1.2.0-beta.261 #45562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
3 commits merged into from
Dec 4, 2020
Merged

Upgrade StyleCopAnalyzers to v1.2.0-beta.261 #45562

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e8dd32b
Upgrade StyleCopAnalyzers to v1.2.0-beta.261
xtqqczze Dec 3, 2020
fd26217
Disable SA1142
xtqqczze Dec 3, 2020
3227ff6
Enable SA1142 except in tests
xtqqczze Dec 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions eng/CodeAnalysis.ruleset
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,6 +316,7 @@
<Rule Id="SA1137" Action="None" /> <!-- Elements should have the same indentation -->
<Rule Id="SA1139" Action="None" /> <!-- Use literal suffix notation instead of casting -->
<Rule Id="SA1141" Action="Warning" /> <!-- Use tuple syntax -->
<Rule Id="SA1142" Action="Warning" /> <!-- Refer to tuple elements by name -->
Copy link
Contributor

@sharwell sharwell Dec 3, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💭 You might disable this one until the next release picks up DotNetAnalyzers/StyleCopAnalyzers#3229.

Since this rule was already disabled in the past, it's not going to be any worse here.

Copy link
Contributor

@sharwell sharwell Dec 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll have a release out hopefully this weekend to pick up this change plus some others related to new C# 9 syntax.

Copy link
Contributor Author

@xtqqczze xtqqczze Dec 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've submitted #45644 for new release.

<Rule Id="SA1200" Action="None" /> <!-- Using directive should appear within a namespace declaration -->
<Rule Id="SA1201" Action="None" /> <!-- Elements should appear in the correct order -->
<Rule Id="SA1202" Action="None" /> <!-- Elements should be ordered by access -->
Expand Down
1 change: 1 addition & 0 deletions eng/CodeAnalysis.test.ruleset
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,6 +315,7 @@
<Rule Id="SA1137" Action="None" /> <!-- Elements should have the same indentation -->
<Rule Id="SA1139" Action="None" /> <!-- Use literal suffix notation instead of casting -->
<Rule Id="SA1141" Action="None" /> <!-- Use tuple syntax -->
<Rule Id="SA1142" Action="None" /> <!-- Refer to tuple elements by name -->
<Rule Id="SA1200" Action="None" /> <!-- Using directive should appear within a namespace declaration -->
<Rule Id="SA1201" Action="None" /> <!-- Elements should appear in the correct order -->
<Rule Id="SA1202" Action="None" /> <!-- Elements should be ordered by access -->
Expand Down
2 changes: 1 addition & 1 deletion eng/Versions.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@
<!-- CoreClr dependencies -->
<MicrosoftNETCoreILAsmVersion>5.0.0-preview.8.20359.4</MicrosoftNETCoreILAsmVersion>
<!-- Libraries dependencies -->
<StyleCopAnalyzersVersion>1.2.0-beta.205</StyleCopAnalyzersVersion>
<StyleCopAnalyzersVersion>1.2.0-beta.261</StyleCopAnalyzersVersion>
<SystemBuffersVersion>4.5.1</SystemBuffersVersion>
<SystemCollectionsVersion>4.3.0</SystemCollectionsVersion>
<SystemCollectionsConcurrentVersion>4.3.0</SystemCollectionsConcurrentVersion>
Expand Down