Skip to content

Add variable lifetime update for GT_STOREIND for arm/arm64 #46059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BruceForstall merged 1 commit into from
Dec 18, 2020
Merged

Add variable lifetime update for GT_STOREIND for arm/arm64 #46059

BruceForstall merged 1 commit into from
Dec 18, 2020

Conversation

@BruceForstall
Copy link
Contributor

@BruceForstall BruceForstall commented Dec 15, 2020

Fix #45557 for arm/arm64

Fixes #46023

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Dec 15, 2020
@BruceForstall
Copy link
Contributor Author

BruceForstall commented Dec 15, 2020

/azp list

@azure-pipelines
Copy link

azure-pipelines bot commented Dec 15, 2020

CI/CD Pipelines for this repository:

@BruceForstall
Copy link
Contributor Author

BruceForstall commented Dec 15, 2020

/azp run runtime-coreclr outerloop

@azure-pipelines
Copy link

azure-pipelines bot commented Dec 15, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@BruceForstall
Copy link
Contributor Author

BruceForstall commented Dec 15, 2020

gcstress failures are 2 timeouts in Linux arm, and 2 failures of #45090

@BruceForstall
Copy link
Contributor Author

BruceForstall commented Dec 15, 2020

@sandreenko @dotnet/jit-contrib PTAL

@BruceForstall
Copy link
Contributor Author

BruceForstall commented Dec 15, 2020

asm diffs for arm64 are essentially the same as for xarch in #45557; extended GC lifetimes where previously they were cut short.

AndyAyersMS
AndyAyersMS approved these changes Dec 15, 2020
View reviewed changes
Copy link
Member

@AndyAyersMS AndyAyersMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should port this to 5.0 as well.

@BruceForstall
Copy link
Contributor Author

BruceForstall commented Dec 18, 2020

I verified that the Linux arm libraries crossgen SPMI asm diffs show the same pattern of fixes: adding stack slots to the tracked GC refs set for a short range.

@BruceForstall BruceForstall merged commit 3b070ca into dotnet:master Dec 18, 2020
@BruceForstall BruceForstall deleted the Fix45557arm branch December 18, 2020 00:36
BruceForstall added a commit to BruceForstall/runtime that referenced this pull request Dec 18, 2020
@BruceForstall
[release/5.0] Add variable lifetime update for GT_STOREIND for arm/arm64
9e6214d 
Port dotnet#46059 to release/5.0

Fix dotnet#45557 for arm/arm64

Fixes dotnet#46023
@BruceForstall BruceForstall mentioned this pull request Dec 18, 2020
Merged
Anipik pushed a commit that referenced this pull request Jan 14, 2021
@BruceForstall
[release/5.0] Add variable lifetime update for GT_STOREIND for arm/ar…
6e68f26 
…m64 (#46206)

Port #46059 to release/5.0

Fix #45557 for arm/arm64

Fixes #46023
@ghost ghost locked as resolved and limited conversation to collaborators Jan 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@AndyAyersMS AndyAyersMS AndyAyersMS approved these changes

@sandreenko sandreenko Awaiting requested review from sandreenko

Assignees

No one assigned

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Test failure: JIT/Regression/JitBlue/Runtime_45557/Runtime_45557/Runtime_45557.sh Process crash with "Internal CLR error" (0x80131506) in Roslyn CI

3 participants

@BruceForstall @AndyAyersMS @Dotnet-GitSync-Bot