[release/5.0] Add variable lifetime update for GT_STOREIND for arm/arm64 #46206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Port dotnet#46059 to release/5.0 Fix dotnet#45557 for arm/arm64 Fixes dotnet#46023
Dotnet-GitSync-Bot
added
the
area-CodeGen-coreclr
BruceForstall
added
the
Servicing-consider
AndyAyersMS
approved these changes
Dec 18, 2020
jeffschwMSFT
removed
the
Servicing-consider
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port #46059 to release/5.0
Fix #45557 for arm/arm64. x86/x64 version of the fix was ported to release/5.0 with #45947
Fixes #46023
Customer Impact
Reported by Roslyn. Bad GC info can lead to an unexplained crash that can't easily be found or worked around.
Regression?
Yes, this is a regression from .NET Core 3.1
Testing
Manual, new unit test, CLR outerloop, SuperPMI asm diffs.
Risk
Low