fix and re-enable TestCheckChildProcessUserAndGroupIds test #46138

adamsitnik · 2020-12-16T13:43:57Z

Explanation: This test gets the current user: name, id, and groups:

runtime/src/libraries/System.Diagnostics.Process/tests/ProcessTests.Unix.cs

Lines 546 to 549 in 721fb97

    
           string userName = GetCurrentRealUserName(); 
        
           string userId = GetUserId(userName); 
        
           string userGroupId = GetUserGroupId(userName); 
        
           string userGroupIds = GetUserGroupIds(userName);

and starts a process using the given user name:

runtime/src/libraries/System.Diagnostics.Process/tests/ProcessTests.Unix.cs

Line 557 in 721fb97

invokeOptions.StartInfo.UserName = userName;

It was failing because so far we were using two different ways of getting the user group Ids:

id -G $username to get the expected ids (called from parent process)
libc.getgroups to get the actual ids (called from child process started as given user)

There are some differences in what id -G and libc.getgroups can return and I've verified that by just comparing the output without starting any new processes (see #28922 (comment) for details).

The solution is to use id -G for getting both the expected and actual ids. The parent process passes the username to the command, the child command passes no username to get it for the current user (the test verifies if the process was started as the given user)

ghost · 2020-12-16T13:44:02Z

Tagging subscribers to this area: @eiriktsarpalis
See info in area-owners.md if you want to be subscribed.

Issue Details

fixes #28922

Author:	adamsitnik
Assignees:	-
Labels:	`area-System.Diagnostics.Process`
Milestone:	-

adamsitnik · 2020-12-16T13:44:46Z

/azp list

azure-pipelines · 2020-12-16T13:44:52Z

CI/CD Pipelines for this repository: coreclr-gc-longrunning coreclr-gc-simulator runtime-coreclr outerloop runtime-coreclr jitstress runtime-coreclr jitstressregs runtime-coreclr jitstress2-jitstressregs runtime-coreclr r2r-extra runtime-coreclr r2r runtime-coreclr runincontext runtime-coreclr crossgen2 runtime-libraries-coreclr outerloop runtime-libraries-coreclr outerloop-windows runtime-libraries-coreclr outerloop-linux runtime-libraries-coreclr outerloop-osx runtime runtime-libraries enterprise-linux runtime-libraries stress-http runtime-libraries stress-ssl runtime-live-build runtime-coreclr crossgen2 outerloop coreclr-release-outerloop-nightly sync-runtime-to-mono runtime-coreclr crossgen2-composite runtime-jit-experimental dotnet-linker-tests runtime-coreclr ilasm runtime-coreclr clrinterpreter runtime-coreclr crossgen2-composite gcstress runtime-libraries-mono outerloop runtime-staging

adamsitnik · 2020-12-16T13:45:22Z

/azp run runtime-libraries-coreclr outerloop-linux

adamsitnik · 2020-12-16T13:45:33Z

/azp run runtime-libraries-coreclr outerloop-osx

azure-pipelines · 2020-12-16T13:45:37Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-12-16T13:45:46Z

Azure Pipelines successfully started running 1 pipeline(s).

adamsitnik · 2020-12-16T14:49:44Z

For OSX outerloop the failing tests are unrelated:

System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_Http2.SocketSendQueueFull_RequestCanceled_ThrowsOperationCanceled
System.IO.Tests.FileSystemWatcher_Multiple_Test.FileSystemWatcher_File_Delet_NotAffectEachOther

adamsitnik · 2020-12-16T14:50:43Z

However, the Mono leg failed for this particular test:

Test System.Diagnostics.Tests.ProcessTests.TestCheckChildProcessUserAndGroupIds has failed. Check the Test tab or this console log: https://helix.dot.net/api/2019-06-17/jobs/b97699fb-54bc-411c-9043-8e640639d1b9/workitems/System.Diagnostics.Process.Tests/console

adamsitnik · 2020-12-16T14:52:01Z


Unhandled Exception:
Xunit.Sdk.XunitException: Expected: 4
Actual: 
   at System.AssertExtensions.Equal[UInt32](HashSet`1 expected, HashSet`1 actual) in /_/src/libraries/Common/tests/TestUtilities/System/AssertExtensions.cs:line 379
   at System.Diagnostics.Tests.ProcessTests.CheckUserAndGroupIds(String userId, String groupId, String groupIdsJoined, String checkGroupsExact) in /_/src/libraries/System.Diagnostics.Process/tests/ProcessTests.Unix.cs:line 533
   at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture) in /_/src/mono/netcore/System.Private.CoreLib/src/System/Reflection/RuntimeMethodInfo.cs:line 378
--- End of stack trace from previous location ---
   at Microsoft.DotNet.RemoteExecutor.Program.Main(String[] args)
[ERROR] FATAL UNHANDLED EXCEPTION: Xunit.Sdk.XunitException: Expected: 4
Actual: 
   at System.AssertExtensions.Equal[UInt32](HashSet`1 expected, HashSet`1 actual) in /_/src/libraries/Common/tests/TestUtilities/System/AssertExtensions.cs:line 379
   at System.Diagnostics.Tests.ProcessTests.CheckUserAndGroupIds(String userId, String groupId, String groupIdsJoined, String checkGroupsExact) in /_/src/libraries/System.Diagnostics.Process/tests/ProcessTests.Unix.cs:line 533
   at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture) in /_/src/mono/netcore/System.Private.CoreLib/src/System/Reflection/RuntimeMethodInfo.cs:line 378
--- End of stack trace from previous location ---
   at Microsoft.DotNet.RemoteExecutor.Program.Main(String[] args)
    System.Diagnostics.Tests.ProcessTests.TestCheckChildProcessUserAndGroupIds [FAIL]
      Microsoft.DotNet.RemoteExecutor.RemoteExecutionException : Remote process failed with an unhandled exception.
      Stack Trace:
        
        Child exception:
          Xunit.Sdk.XunitException: Expected: 4
        Actual: 
        /_/src/libraries/Common/tests/TestUtilities/System/AssertExtensions.cs(379,0): at System.AssertExtensions.Equal[UInt32](HashSet`1 expected, HashSet`1 actual)
        /_/src/libraries/System.Diagnostics.Process/tests/ProcessTests.Unix.cs(533,0): at System.Diagnostics.Tests.ProcessTests.CheckUserAndGroupIds(String userId, String groupId, String groupIdsJoined, String checkGroupsExact)
        /_/src/mono/netcore/System.Private.CoreLib/src/System/Reflection/RuntimeMethodInfo.cs(378,0): at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
        
        Child process:
          System.Diagnostics.Process.Tests, Version=6.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51 System.Diagnostics.Tests.ProcessTests Int32 CheckUserAndGroupIds(System.String, System.String, System.String, System.String)
        
        Child arguments:
          1001, 4, 4, True

adamsitnik · 2020-12-18T09:58:43Z

/azp run runtime-libraries-coreclr outerloop-linux

azure-pipelines · 2020-12-18T09:58:56Z

Azure Pipelines successfully started running 1 pipeline(s).

adamsitnik · 2020-12-18T12:15:47Z

/azp run runtime-libraries-coreclr outerloop-linux

azure-pipelines · 2020-12-18T12:16:00Z

Azure Pipelines successfully started running 1 pipeline(s).

adamsitnik · 2020-12-18T12:24:42Z

/azp run runtime-libraries-coreclr outerloop-osx

azure-pipelines · 2020-12-18T12:24:57Z

Azure Pipelines successfully started running 1 pipeline(s).

adamsitnik · 2020-12-18T14:09:09Z

/azp run runtime-libraries-coreclr outerloop-linux

adamsitnik · 2020-12-18T14:09:18Z

/azp run runtime-libraries-coreclr outerloop-osx

azure-pipelines · 2020-12-18T14:09:23Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-12-18T14:09:30Z

Azure Pipelines successfully started running 1 pipeline(s).

… 116 126 to get the current

adamsitnik · 2020-12-18T19:13:50Z

/azp run runtime-libraries-coreclr outerloop-linux

adamsitnik · 2020-12-18T19:14:00Z

/azp run runtime-libraries-coreclr outerloop-osx

azure-pipelines · 2020-12-18T19:14:06Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-12-18T19:14:12Z

Azure Pipelines successfully started running 1 pipeline(s).

adamsitnik · 2020-12-18T19:18:50Z

/azp run runtime-libraries-coreclr outerloop-linux

adamsitnik · 2020-12-18T19:18:59Z

/azp run runtime-libraries-coreclr outerloop-osx

azure-pipelines · 2020-12-18T19:19:03Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-12-18T19:19:11Z

Azure Pipelines successfully started running 1 pipeline(s).

adamsitnik · 2020-12-21T10:00:27Z

The test that I wanted to fix has passed (it was failing at the beginning), the current CI failures are not related:

.packages/microsoft.dotnet.helix.sdk/6.0.0-beta.20615.4/tools/Microsoft.DotNet.Helix.Sdk.MultiQueue.targets(76,5): error : (NETCORE_ENGINEERING_TELEMETRY=Test) Work item System.Text.RegularExpressions.Tests in job eb0e5f55-01bf-4a05-ae2e-a449442a2cac has failed.
Failure log: https://helix.dot.net/api/2019-06-17/jobs/eb0e5f55-01bf-4a05-ae2e-a449442a2cac/workitems/System.Text.RegularExpressions.Tests/console

.packages/microsoft.dotnet.helix.sdk/6.0.0-beta.20615.4/tools/Microsoft.DotNet.Helix.Sdk.MultiQueue.targets(76,5): error : (NETCORE_ENGINEERING_TELEMETRY=Test) Work item System.Text.RegularExpressions.Tests in job eb0e5f55-01bf-4a05-ae2e-a449442a2cac has failed.
Failure log: https://helix.dot.net/api/2019-06-17/jobs/eb0e5f55-01bf-4a05-ae2e-a449442a2cac/workitems/System.Text.RegularExpressions.Tests/console

wfurt · 2020-12-21T17:48:59Z

I feel this is move wrong direction. This starts new process and add dependency on finding the right executable. I think that was OK for the test where we control the environment and overhead does not matter. Further more, it can report group the process actually does not have. I'm wondering if that can cause issues does the road.

adamsitnik · 2020-12-21T23:42:54Z

it can report group the process actually does not have

@wfurt good point, I've read the docs one more time and I think I've found a "proper fix", PTAL at #46302

try to re-enable TestCheckChildProcessUserAndGroupIds test

4646be2

Dotnet-GitSync-Bot added the area-System.Diagnostics.Process label Dec 16, 2020

adamsitnik added the disabled-test The test is disabled in source code against the issue label Dec 16, 2020

adamsitnik added this to the 6.0.0 milestone Dec 16, 2020

adamsitnik added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Dec 16, 2020

lets see if id -G returns the same info as getgroups method from libc

eba057f

adamsitnik mentioned this pull request Dec 18, 2020

Test failure: System.Diagnostics.Tests.ProcessTests/TestCheckChildProcessUserAndGroupIds #28922

Closed

use one way of getting expected and actual data in both processes

d0371c9

the input can be empty

b280668

runfoapp bot mentioned this pull request Dec 18, 2020

Inability to unzip assets during build on Unix x64 #32805

Closed

use 1000 4 24 27 30 46 116 126 to get expected and 1000 4 24 27 30 46…

b6b82d4

… 116 126 to get the current

remove changes that are not needed

721fb97

adamsitnik changed the title ~~try to re-enable TestCheckChildProcessUserAndGroupIds test~~ fix and re-enable TestCheckChildProcessUserAndGroupIds test Dec 18, 2020

adamsitnik removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Dec 18, 2020

runfoapp bot mentioned this pull request Dec 18, 2020

Bundle_Is_Extracted test failing intermittently on Linux #43316

Closed

adamsitnik requested review from danmoseley, eiriktsarpalis, tmds and wfurt December 21, 2020 10:01

adamsitnik closed this Dec 21, 2020

ghost locked as resolved and limited conversation to collaborators Jan 21, 2021

adamsitnik deleted the 28922 branch July 2, 2021 11:11

	string userName = GetCurrentRealUserName();
	string userId = GetUserId(userName);
	string userGroupId = GetUserGroupId(userName);
	string userGroupIds = GetUserGroupIds(userName);

fix and re-enable TestCheckChildProcessUserAndGroupIds test #46138

fix and re-enable TestCheckChildProcessUserAndGroupIds test #46138

Uh oh!

Conversation

adamsitnik commented Dec 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Dec 16, 2020

Uh oh!

adamsitnik commented Dec 16, 2020

Uh oh!

azure-pipelines bot commented Dec 16, 2020

Uh oh!

adamsitnik commented Dec 16, 2020

Uh oh!

adamsitnik commented Dec 16, 2020

Uh oh!

azure-pipelines bot commented Dec 16, 2020

Uh oh!

azure-pipelines bot commented Dec 16, 2020

Uh oh!

adamsitnik commented Dec 16, 2020

Uh oh!

adamsitnik commented Dec 16, 2020

Uh oh!

adamsitnik commented Dec 16, 2020

Uh oh!

adamsitnik commented Dec 18, 2020

Uh oh!

azure-pipelines bot commented Dec 18, 2020

Uh oh!

adamsitnik commented Dec 18, 2020

Uh oh!

azure-pipelines bot commented Dec 18, 2020

Uh oh!

adamsitnik commented Dec 18, 2020

Uh oh!

azure-pipelines bot commented Dec 18, 2020

Uh oh!

adamsitnik commented Dec 18, 2020

Uh oh!

adamsitnik commented Dec 18, 2020

Uh oh!

azure-pipelines bot commented Dec 18, 2020

Uh oh!

azure-pipelines bot commented Dec 18, 2020

Uh oh!

adamsitnik commented Dec 18, 2020

Uh oh!

adamsitnik commented Dec 18, 2020

Uh oh!

azure-pipelines bot commented Dec 18, 2020

Uh oh!

azure-pipelines bot commented Dec 18, 2020

Uh oh!

adamsitnik commented Dec 18, 2020

Uh oh!

adamsitnik commented Dec 18, 2020

Uh oh!

azure-pipelines bot commented Dec 18, 2020

Uh oh!

azure-pipelines bot commented Dec 18, 2020

Uh oh!

adamsitnik commented Dec 21, 2020

Uh oh!

wfurt commented Dec 21, 2020

Uh oh!

adamsitnik commented Dec 21, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

adamsitnik commented Dec 16, 2020 •

edited

Loading