Skip to content

fix and re-enable TestCheckChildProcessUserAndGroupIds test #46138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
adamsitnik wants to merge 6 commits into from
Closed

fix and re-enable TestCheckChildProcessUserAndGroupIds test #46138

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4646be2
try to re-enable TestCheckChildProcessUserAndGroupIds test
adamsitnik Dec 16, 2020
eba057f
lets see if id -G returns the same info as getgroups method from libc
adamsitnik Dec 18, 2020
d0371c9
use one way of getting expected and actual data in both processes
adamsitnik Dec 18, 2020
b280668
the input can be empty
adamsitnik Dec 18, 2020
b6b82d4
use 1000 4 24 27 30 46 116 126 to get expected and 1000 4 24 27 30 46…
adamsitnik Dec 18, 2020
721fb97
remove changes that are not needed
adamsitnik Dec 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 10 additions & 25 deletions src/libraries/System.Diagnostics.Process/tests/ProcessTests.Unix.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -530,18 +530,17 @@ private static int CheckUserAndGroupIds(string userId, string groupId, string gr

if (bool.Parse(checkGroupsExact))
{
AssertExtensions.Equal(expectedGroups, GetGroups());
AssertExtensions.Equal(expectedGroups, GetCurrentUserGroupIds());
}
else
{
Assert.Subset(expectedGroups, GetGroups());
Assert.Subset(expectedGroups, GetCurrentUserGroupIds());
}

return RemoteExecutor.SuccessExitCode;
}

[ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/28922", TestPlatforms.AnyUnix)]
public unsafe void TestCheckChildProcessUserAndGroupIds()
{
string userName = GetCurrentRealUserName();
Expand Down Expand Up @@ -620,10 +619,17 @@ private static string GetUserGroupId(string username)
private static string GetUserGroupIds(string username)
{
string[] groupIds = StartAndReadToEnd("id", new[] { "-G", username })
.Split(new[] { ' ', '\n' }, StringSplitOptions.RemoveEmptyEntries);
.Split(new[] { ' ', '\n' }, StringSplitOptions.RemoveEmptyEntries);
return string.Join(",", groupIds.Select(s => uint.Parse(s)).OrderBy(id => id));
}

private static HashSet<uint> GetCurrentUserGroupIds()
{
string[] groupIds = StartAndReadToEnd("id", new[] { "-G" })
.Split(new[] { ' ', '\n' }, StringSplitOptions.RemoveEmptyEntries);
return new HashSet<uint>(groupIds.Select(s => uint.Parse(s)));
}

private static string GetCurrentRealUserName()
{
string realUserName = geteuid() == 0 ?
Expand Down Expand Up @@ -906,27 +912,6 @@ private static void ChMod(string filename, string mode)
[DllImport("libc")]
private static extern uint getgid();

[DllImport("libc", SetLastError = true)]
private static extern unsafe int getgroups(int size, uint* list);

private static unsafe HashSet<uint> GetGroups()
{
int maxSize = 128;
Span<uint> groups = stackalloc uint[maxSize];
fixed (uint* pGroups = groups)
{
int rv = getgroups(maxSize, pGroups);
if (rv == -1)
{
// If this throws with EINVAL, maxSize should be increased.
throw new Win32Exception();
}

// Return this as a HashSet to filter out duplicates.
return new HashSet<uint>(groups.Slice(0, rv).ToArray());
}
}

[DllImport("libc")]
private static extern int seteuid(uint euid);

Expand Down