-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Fix ILVerify Default Method Verification #46404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Agreed, finding the solution for
|
|
@am11 |
|
If I were to submit a PR to document the way to build this project should this be in |
jkotas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
This would be much appreciated!
The documentation is in https://github.com/dotnet/runtime/blob/master/src/coreclr/tools/ILVerify/README.md currently. I think it would be best to keep updating this document with ILVerify specific testing instructions. |
|
@jkotas should a separate PR be preferable or shall I append it to this one? |
|
Could you please submit a new PR with the documentation changes? |
Fixes #46236
The fix involves checking whether an interface method has a method body, as opposed to static, to avoid the search for an implementation in a child class.
I think the ILVerify building/testing workflow should be documented somewhere. It took me quite some time to figure out that the tests were only built when using
priority=1.Furthermore, I ran into the issue of running
dotnet testin the ILVerify tests folder. This supposedly permanently breaks your build until you clean all artifacts and recompile (#43967).Finding and fixing the issue took about half an hour, managing to get the tests working as a first time contributor to the ILVerify tool took about 4 hours.