Skip to content

Fix ILVerify Default Method Verification #46404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkotas merged 2 commits into from
Dec 27, 2020
Merged

Fix ILVerify Default Method Verification #46404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d1abf9
Fix ILVerify Default Method Verification (#43967)
bbartels Dec 26, 2020
93c6299
Fixed test
bbartels Dec 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/coreclr/tools/ILVerification/TypeVerifier.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ public void VerifyInterfaces()
// Look for missing method implementation
foreach (MethodDesc method in implementedInterface.InterfaceType.GetAllMethods())
{
if (method.Signature.IsStatic)
if (!method.IsAbstract)
{
continue;
}
Expand Down
51 changes: 51 additions & 0 deletions src/tests/ilverify/ILTests/InterfaceImplementation.il
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,3 +448,54 @@
{
}
}

.class public auto ansi beforefieldinit ChildClassDoesNotImplementDefaultInterfaceMethod_ValidType_Valid
extends [System.Runtime]System.Object
implements IDefaultImplInterface
{
.method public hidebysig specialname rtspecialname
instance void .ctor () cil managed
{
.maxstack 8

IL_0000: ldarg.0
IL_0001: call instance void [System.Runtime]System.Object::.ctor()
IL_0006: nop
IL_0007: ret
}
}

.class public auto ansi beforefieldinit ChildClassDoesImplementDefaultInterfaceMethod_ValidType_Valid
extends [System.Runtime]System.Object
implements IDefaultImplInterface
{
.method public final hidebysig newslot virtual
instance void DefaultImplementation () cil managed
{
.maxstack 8

IL_0000: ret
}

.method public hidebysig specialname rtspecialname
instance void .ctor () cil managed
{
.maxstack 8

IL_0000: ldarg.0
IL_0001: call instance void [System.Runtime]System.Object::.ctor()
IL_0006: nop
IL_0007: ret
}
}

.class interface public auto ansi abstract IDefaultImplInterface
{
.method public hidebysig newslot virtual
instance void DefaultImplementation () cil managed
{
.maxstack 8

IL_0000: ret
}
}