Skip to content

Make sure pal_icushim_static.c is linked in even if no symbols are used from it, so the EMSCRIPTEN_KEEPALIVE functions in it are actually kept.#48550

Merged
radical merged 1 commit intodotnet:masterfrom
vargaz:icu-keep
Feb 22, 2021

Conversation

@vargaz
Copy link
Copy Markdown
Contributor

@vargaz vargaz commented Feb 20, 2021

No description provided.

@ghost
Copy link
Copy Markdown

ghost commented Feb 20, 2021

Tagging subscribers to this area: @tarek, @safern
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: vargaz
Assignees: -
Labels:

area-System.Globalization

Milestone: -

@ghost
Copy link
Copy Markdown

ghost commented Feb 20, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: vargaz
Assignees: -
Labels:

arch-wasm, area-System.Globalization

Milestone: -

@vargaz vargaz requested a review from radical February 20, 2021 07:33
…ed from it, so the EMSCRIPTEN_KEEPALIVE functions in it are actually kept.
Copy link
Copy Markdown
Member

@lewing lewing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@radical radical merged commit 3473d30 into dotnet:master Feb 22, 2021
@radical
Copy link
Copy Markdown
Member

radical commented Feb 22, 2021

/azp backport release/6.0-preview2

@radical
Copy link
Copy Markdown
Member

radical commented Feb 22, 2021

/backport release/6.0-preview2

@radical
Copy link
Copy Markdown
Member

radical commented Feb 22, 2021

/azp help

@radical
Copy link
Copy Markdown
Member

radical commented Feb 22, 2021

/backport to release/6.0-preview2

@github-actions
Copy link
Copy Markdown
Contributor

@radical an error occurred while backporting to , please check the run log for details!

Error: @radical is not a repo collaborator, backporting is not allowed.

@CoffeeFlux
Copy link
Copy Markdown
Contributor

/backport to release/6.0-preview2

@github-actions
Copy link
Copy Markdown
Contributor

Started backporting to release/6.0-preview2: https://github.com/dotnet/runtime/actions/runs/590792492

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants