[release/6.0-preview2] Make sure pal_icushim_static.c is linked in even if no symbols are used from it, so the EMSCRIPTEN_KEEPALIVE functions in it are actually kept.#48629
Merged
marek-safar merged 1 commit intorelease/6.0-preview2from Feb 23, 2021
Conversation
…ed from it, so the EMSCRIPTEN_KEEPALIVE functions in it are actually kept.
ghost
added
the
|
Tagging subscribers to this area: @tarekgh, @safern Issue DetailsBackport of #48550 to release/6.0-preview2 /cc @CoffeeFlux @vargaz Customer ImpactTestingRisk
|
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsBackport of #48550 to release/6.0-preview2 /cc @CoffeeFlux @vargaz Customer ImpactTestingRisk
|
Member
vargaz
approved these changes
Feb 23, 2021
marek-safar
approved these changes
Feb 23, 2021
Contributor
|
/cc @mmitche |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #48550 to release/6.0-preview2
/cc @CoffeeFlux @vargaz
Customer Impact
Testing
Risk