Skip to content

Conversation

@hoyosjs
Copy link
Member

@hoyosjs hoyosjs commented Mar 3, 2021

Reverts #48858

Looks like this change broke the official build as the package seems to be shipping in nightly with a stable version. Opening a revert in case we need it.

@ghost
Copy link

ghost commented Mar 3, 2021

Tagging subscribers to this area: @eerhardt, @maryamariyan
See info in area-owners.md if you want to be subscribed.

Issue Details

Reverts #48858

Looks like this change broke the official build as the package seems to be shipping in nightly with a stable version. Opening a revert in case we need it.

Author: hoyosjs
Assignees: -
Labels:

area-Extensions-DependencyInjection

Milestone: -

@hoyosjs
Copy link
Member Author

hoyosjs commented Mar 3, 2021

@ViktorHofer
Copy link
Member

ViktorHofer commented Mar 3, 2021

Closing in favor of #49053. Thanks Juan.

@ViktorHofer ViktorHofer closed this Mar 3, 2021
@ViktorHofer ViktorHofer deleted the revert-48858-DI.Spec.Tests branch March 3, 2021 11:46
@ericstj
Copy link
Member

ericstj commented Mar 3, 2021

Good job build system catching my mistake. Thank you @hoyosjs reacting fast to fix this. Thank you @ViktorHofer for finding the right fix (fyi @Anipik who might be impacted for other CSProj-produced-packages).

@ghost ghost locked as resolved and limited conversation to collaborators Apr 2, 2021
@karelz karelz added this to the 6.0.0 milestone May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants