Don't default PackageVersion for NuGet Pack task generated packages #49053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifying a default PackageVersion causes Arcade's calculated Version not be used and instead the VersionSuffix-less Version be used which indicates a stable packages. That later fails during publishing to a non stable feed. This is a mitigation for the official build breaks and a better implementation that supports not reving the patch major during servicing needs to be figured out.
|
Tagging subscribers to this area: @safern, @ViktorHofer, @Anipik Issue DetailsSpecifying a default PackageVersion causes Arcade's calculated This is a mitigation for the official build breaks and a better Fixes #49051
|
hoyosjs
approved these changes
Mar 3, 2021
Member
Author
|
Merging to unblock official builds. Verified the generated package version locally for both dev, ci and official builds. |
This was referenced Mar 3, 2021
Member
|
Thank you @ViktorHofer, just saw this break. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifying a default PackageVersion causes Arcade's calculated
Version not be used and instead the VersionSuffix-less Version be used
which indicates a stable packages. That later fails during publishing to
a non stable feed.
This is a mitigation for the official build breaks and a better
implementation that supports not reving the patch major during servicing
needs to be figured out.
Fixes #49051