Disable binplacing for DependencyInjection.Specification.Tests

[ericstj]

No description provided.

[ghost]

Tagging subscribers to this area: @eerhardt, @maryamariyan
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Author:	ericstj
Assignees:	-
Labels:	area-Extensions-DependencyInjection
Milestone:	-

[eerhardt]

LGTM

[ericstj]

@ViktorHofer @briansull should we merge this immediately to unblock builds? It wasn't clear to me from #48858 (comment) how blocking the failure was.

[BruceForstall]

It affects our post-merge rolling "outerloop" CI job: https://dev.azure.com/dnceng/public/_build?definitionId=655&_a=summary

As well as any R2R coreclr job.

[ericstj]

@BruceForstall is there anything that's going to validate this fix as part of the CI process? What's the quickest way to unblock you?

[ViktorHofer]

Given the simplicity of the change I tend towards fast merge. Merging.

[ericstj]

My thoughts as well @ViktorHofer. I'll own the risk here. If anything breaks ping me and I'll back stuff out.

[BruceForstall]

I would manually kick off an outerloop job to validate, but it should automatically kick off in about 15 minutes, so I'll just let that happen.

https://dev.azure.com/dnceng/public/_build?definitionId=655

[briansull]

Does this change remove System.TestStructs.dll from the CORE_ROOT directory?
As that is the assembly that fails to compile in the R2RTest task

[ericstj]

@briansull I don’t think System.TestStructs.dll was present.

Error was

Could not load file or assembly 'System.TestStructs, Version=1.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the file specified

That failure was due to Microsoft.Extensions.DependencyInjection.Specification.Tests which referenced it without copying it. The same assembly referenced others as well which likely would have been problems after TestStructs. This change prevents that test assembly from being copied to the directory consumed to construct CORE_ROOT.