Skip to content

Conversation

@briansull
Copy link
Contributor

No description provided.

@ericstj
Copy link
Member

ericstj commented Mar 3, 2021

This won't be the only dependency from that assembly. It also uses Xunit (xunit.core.dll, xunit.assert.dll). I'll have a different PR to fix this.

@ericstj
Copy link
Member

ericstj commented Mar 3, 2021

#49067

@briansull
Copy link
Contributor Author

/azp run runtime-coreclr r2r-extra

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@BruceForstall
Copy link
Contributor

btw, this problem affects all R2R coreclr test runs, including our top-level CI "outerloop" job : https://dev.azure.com/dnceng/public/_build?definitionId=655&_a=summary

@ericstj
Copy link
Member

ericstj commented Mar 3, 2021

@BruceForstall please see #49067 which may be the better fix. Also would help to have others comment on discussion here: #48858

@briansull
Copy link
Contributor Author

This change is inherently safe as it just adds the name System.TestStructs.dll to the list of assemblies that we don't try to compile. It doesn't matter if that assembly it exists or doesn't exist.

Your change talks about not binplacing another assembly: DependencyInjection.Specification.Tests

@ericstj
Copy link
Member

ericstj commented Mar 3, 2021

True, but I don’t think that’s the problem that broke the build. I believe the build was broken due to this assembly being absent. I fixed that by removing the assembly that references this one from the build directory being crossgen’ed.

@briansull
Copy link
Contributor Author

Closing this PR

@briansull briansull closed this Mar 3, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Apr 2, 2021
@karelz karelz added this to the 6.0.0 milestone May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants