Modernize DiagnosticsHandler tests #53870
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsEffectively all tests here were in OuterLoop/disabled, even those that were not hitting any servers. This PR:
Fixes #23167 (re-enables the tests disabled against it)
|
geoffkizer
reviewed
Jun 8, 2021
src/libraries/System.Net.Http/tests/FunctionalTests/DiagnosticsTests.cs
Outdated
Show resolved
Hide resolved
geoffkizer
reviewed
Jun 8, 2021
src/libraries/System.Net.Http/tests/FunctionalTests/DiagnosticsTests.cs
Outdated
Show resolved
Hide resolved
geoffkizer
reviewed
Jun 8, 2021
src/libraries/System.Net.Http/tests/FunctionalTests/SocketsHttpHandlerTest.cs
Outdated
Show resolved
Hide resolved
geoffkizer
suggested changes
Jun 8, 2021
Contributor
geoffkizer
left a comment
geoffkizer
left a comment
There was a problem hiding this comment.
Generally looks good -- nice to see this get modernized. A few small issues or things to consider.
SemaphoreSlim => TCS, Guid => nosuchhost.invalid, Http20 => Http2
geoffkizer
approved these changes
Jun 8, 2021
|
Hello @MihaZupan! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
ghost
locked as resolved and limited conversation to collaborators
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Effectively all tests here were in OuterLoop/disabled, even those that were not hitting any servers.
This PR:
SpinWait.SpinUntilwithSemaphoreSlimwhere needed)Hierarchicalformat wasn't being tested)Fixes #23167 (re-enables the tests disabled against it)