Don't use a remote server in SendAsync_HttpTracingEnabled_Succeeds #54240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsIn #53870 I added HTTP/2 as an argument for diagnostics tests and this outerloop test I left alone started failing. This PR removes the use of a remote endpoint in the test since a loopback will already exercise code paths that emit some events.
|
geoffkizer
approved these changes
Jun 15, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #53870 I added HTTP/2 as an argument for diagnostics tests and this outerloop test I left alone started failing.
This PR removes the use of a remote endpoint in the test since a loopback will already exercise code paths that emit some events.
As such, this test no longer needs to be disabled & in outerloop.
Fixes #1477
Fixes #53970