Support generating log methods in nested classes#54180
Merged
maryamariyan merged 6 commits intodotnet:mainfrom Jun 15, 2021
Merged
Support generating log methods in nested classes#54180maryamariyan merged 6 commits intodotnet:mainfrom
maryamariyan merged 6 commits intodotnet:mainfrom
Conversation
|
Tagging subscribers to this area: @maryamariyan Issue Details
|
Contributor
Author
|
Notes for review:
|
24 tasks
eerhardt
reviewed
Jun 14, 2021
...ns/tests/Microsoft.Extensions.Logging.Generators.Tests/LoggerMessageGeneratorEmitterTests.cs
Outdated
Show resolved
Hide resolved
eerhardt
reviewed
Jun 14, 2021
src/libraries/Microsoft.Extensions.Logging.Abstractions/gen/LoggerMessageGenerator.Emitter.cs
Outdated
Show resolved
Hide resolved
eerhardt
reviewed
Jun 14, 2021
src/libraries/Microsoft.Extensions.Logging.Abstractions/gen/LoggerMessageGenerator.Parser.cs
Outdated
Show resolved
Hide resolved
eerhardt
reviewed
Jun 14, 2021
src/libraries/Microsoft.Extensions.Logging.Abstractions/gen/LoggerMessageGenerator.Parser.cs
Outdated
Show resolved
Hide resolved
eerhardt
reviewed
Jun 14, 2021
src/libraries/Microsoft.Extensions.Logging.Abstractions/gen/LoggerMessageGenerator.Parser.cs
Outdated
Show resolved
Hide resolved
eerhardt
reviewed
Jun 14, 2021
src/libraries/Microsoft.Extensions.Logging.Abstractions/gen/LoggerMessageGenerator.Parser.cs
Outdated
Show resolved
Hide resolved
eerhardt
reviewed
Jun 14, 2021
src/libraries/Microsoft.Extensions.Logging.Abstractions/gen/LoggerMessageGenerator.Emitter.cs
Outdated
Show resolved
Hide resolved
eerhardt
reviewed
Jun 14, 2021
src/libraries/Microsoft.Extensions.Logging.Abstractions/gen/LoggerMessageGenerator.Emitter.cs
Outdated
Show resolved
Hide resolved
- Add test for non static nested case - Add support for log method directly in structs - Support log methods in nested records/structs
- Undo support for loggers directrly under struct
maryamariyan
commented
Jun 15, 2021
src/libraries/Microsoft.Extensions.Logging.Abstractions/gen/LoggerMessageGenerator.Parser.cs
Show resolved
Hide resolved
eerhardt
reviewed
Jun 15, 2021
src/libraries/Microsoft.Extensions.Logging.Abstractions/gen/LoggerMessageGenerator.Parser.cs
Outdated
Show resolved
Hide resolved
eerhardt
reviewed
Jun 15, 2021
src/libraries/Microsoft.Extensions.Logging.Abstractions/gen/LoggerMessageGenerator.Parser.cs
Outdated
Show resolved
Hide resolved
eerhardt
reviewed
Jun 15, 2021
src/libraries/Microsoft.Extensions.Logging.Abstractions/gen/LoggerMessageGenerator.Emitter.cs
Outdated
Show resolved
Hide resolved
eerhardt
approved these changes
Jun 15, 2021
Member
eerhardt
left a comment
eerhardt
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the good work here!
maryamariyan
force-pushed
the
support-nested-logs
branch
2 times, most recently
from
6f872e5 to
5e9f356
Compare
maryamariyan
force-pushed
the
support-nested-logs
branch
from
5e9f356 to
61e76f5
Compare
Contributor
Author
|
/backport to release/5.0-preview6 |
Contributor
|
Started backporting to release/5.0-preview6: https://github.com/dotnet/runtime/actions/runs/940940800 |
Contributor
|
@maryamariyan an error occurred while backporting to release/5.0-preview6, please check the run log for details! Error: The specified backport target branch release/5.0-preview6 wasn't found in the repo. |
Contributor
Author
|
/backport to release/6.0-preview6 |
Contributor
|
Started backporting to release/6.0-preview6: https://github.com/dotnet/runtime/actions/runs/940950152 |
Contributor
Author
|
CI results from later commits in the PR: buildId 1188639 More CI related to the PR here: |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #52301