[release/6.0-preview6] Support generating log methods in nested classes#54248
Merged
Anipik merged 6 commits intorelease/6.0-preview6from Jun 17, 2021
Merged
Conversation
…se - Add support for log method directly in structs - Support log methods in nested records/structs
|
Tagging subscribers to this area: @maryamariyan Issue DetailsBackport of #54180 to release/6.0-preview6 /cc @maryamariyan Customer ImpactTestingRisk
|
maryamariyan
added
the
Servicing-consider
Contributor
|
I think the report in https://dev.azure.com/dnceng/public/_build/results?buildId=1189154&view=results is for this PR. |
ericstj
approved these changes
Jun 16, 2021
Anipik
added
Servicing-approved
Contributor
|
This was approved offline. |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #54180 to release/6.0-preview6
/cc @maryamariyan
Customer Impact
A common logging pattern is to put all the logging related methods in a nested class of the service that needs to log. This feature request was a key feedback received in preview 4 by the ASP.NET in dotnet/aspnetcore#32414 (comment)
Linked issue #52301
Testing
Tests have been added for new scenarios and there are no regressions to existing tests.
Risk
Low - New capability support