Skip to content

[MacCatalyst][libraries] Update MacCatalyst as Case Preserving for tests #57167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adamsitnik merged 1 commit into from
Aug 11, 2021
Merged

[MacCatalyst][libraries] Update MacCatalyst as Case Preserving for tests #57167

adamsitnik merged 1 commit into from
Aug 11, 2021

Conversation

@mdh1418
Copy link
Member

@mdh1418 mdh1418 commented Aug 10, 2021

Fixes #52857

On MacCatalyst x64, checking the values of DoesCaseSensitiveComparisons

System.Exception : 
testDir.FullName: /var/folders/yq/rwgq0l0d1yxgz5wtk2bvw0ww0000gn/T/Directory_Exists_cwmz21ja.jq3/DoesCaseSensitiveComparisons_241_b48c73fe
testDir.FullName.ToUpperInvariant(): /VAR/FOLDERS/YQ/RWGQ0L0D1YXGZ5WTK2BVW0WW0000GN/T/DIRECTORY_EXISTS_CWMZ21JA.JQ3/DOESCASESENSITIVECOMPARISONS_241_B48C73FE
testDir.FullName.ToLowerInvariant(): /var/folders/yq/rwgq0l0d1yxgz5wtk2bvw0ww0000gn/t/directory_exists_cwmz21ja.jq3/doescasesensitivecomparisons_241_b48c73fe

asserts true for testDir.FullName.ToUpperInvariant(), which suggests that MacCatalyst is case preserving like OSX

As a result, this PR updates the CaseInsensitivePlatforms and CaseSensitivePlatforms to have MacCatalyst behave like OSX.

@ghost ghost added the area-System.IO label Aug 10, 2021
@ghost
Copy link

ghost commented Aug 10, 2021

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #52857

On MacCatalyst x64, checking the values of DoesCaseSensitiveComparisons

System.Exception : 
testDir.FullName: /var/folders/yq/rwgq0l0d1yxgz5wtk2bvw0ww0000gn/T/Directory_Exists_cwmz21ja.jq3/DoesCaseSensitiveComparisons_241_b48c73fe
testDir.FullName.ToUpperInvariant(): /VAR/FOLDERS/YQ/RWGQ0L0D1YXGZ5WTK2BVW0WW0000GN/T/DIRECTORY_EXISTS_CWMZ21JA.JQ3/DOESCASESENSITIVECOMPARISONS_241_B48C73FE
testDir.FullName.ToLowerInvariant(): /var/folders/yq/rwgq0l0d1yxgz5wtk2bvw0ww0000gn/t/directory_exists_cwmz21ja.jq3/doescasesensitivecomparisons_241_b48c73fe

asserts true for testDir.FullName.ToUpperInvariant(), which suggests that MacCatalyst is case preserving like OSX

As a result, this PR updates the CaseInsensitivePlatforms and CaseSensitivePlatforms to have MacCatalyst behave like OSX.

Author: mdh1418
Assignees: -
Labels:

area-System.IO
Milestone: -

adamsitnik
adamsitnik approved these changes Aug 11, 2021
View reviewed changes
Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the fix @mdh1418 !

@adamsitnik adamsitnik added this to the 6.0.0 milestone Aug 11, 2021
@adamsitnik adamsitnik merged commit 126e29c into dotnet:main Aug 11, 2021
@mdh1418 mdh1418 deleted the macCatalyst_case_preserving branch August 11, 2021 12:58
@ghost ghost locked as resolved and limited conversation to collaborators Sep 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@adamsitnik adamsitnik adamsitnik approved these changes

@directhex directhex Awaiting requested review from directhex

@steveisok steveisok Awaiting requested review from steveisok

+1 more reviewer

@filipnavara filipnavara filipnavara approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-System.IO

Projects

None yet

Milestone

6.0.0

Development

Successfully merging this pull request may close these issues.

[MacCatalyst][libraries] System.IO.FileSystem.Tests failures

3 participants

@mdh1418 @filipnavara @adamsitnik