Skip to content

[MacCatalyst][libraries] Update MacCatalyst as Case Preserving for tests #57167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamsitnik merged 1 commit into from
Aug 11, 2021
Merged

[MacCatalyst][libraries] Update MacCatalyst as Case Preserving for tests #57167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/libraries/System.IO.FileSystem/tests/Directory/Exists.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,6 @@ public void DoesCaseInsensitiveInvariantComparisons()

[Fact]
[PlatformSpecific(CaseSensitivePlatforms)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/52857", TestPlatforms.MacCatalyst)]
public void DoesCaseSensitiveComparisons()
{
DirectoryInfo testDir = Directory.CreateDirectory(GetTestFilePath());
Expand Down
1 change: 0 additions & 1 deletion src/libraries/System.IO.FileSystem/tests/DirectoryInfo/Exists.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@ public void CaseInsensitivity()

[Fact]
[PlatformSpecific(CaseSensitivePlatforms)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/52857", TestPlatforms.MacCatalyst)]
public void CaseSensitivity()
{
Assert.False(new DirectoryInfo(TestDirectory.ToUpperInvariant()).Exists);
Expand Down
1 change: 0 additions & 1 deletion src/libraries/System.IO.FileSystem/tests/File/Exists.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,6 @@ public void DoesCaseInsensitiveInvariantComparions()

[Fact]
[PlatformSpecific(CaseSensitivePlatforms)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/52857", TestPlatforms.MacCatalyst)]
public void DoesCaseSensitiveComparisons()
{
FileInfo testFile = new FileInfo(GetTestFilePath());
Expand Down
1 change: 0 additions & 1 deletion src/libraries/System.IO.FileSystem/tests/FileInfo/Exists.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@ public void CaseInsensitivity()

[Fact]
[PlatformSpecific(CaseSensitivePlatforms)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/52857", TestPlatforms.MacCatalyst)]
public void CaseSensitivity()
{
string path = GetTestFilePath();
Expand Down
6 changes: 3 additions & 3 deletions src/libraries/System.IO.FileSystem/tests/FileSystemTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ public abstract partial class FileSystemTest : FileCleanupTestBase
{
public static readonly byte[] TestBuffer = { 0xBA, 0x5E, 0xBA, 0x11, 0xF0, 0x07, 0xBA, 0x11 };

protected const TestPlatforms CaseInsensitivePlatforms = TestPlatforms.Windows | TestPlatforms.OSX;
protected const TestPlatforms CaseSensitivePlatforms = TestPlatforms.AnyUnix & ~TestPlatforms.OSX;
protected const TestPlatforms CaseInsensitivePlatforms = TestPlatforms.Windows | TestPlatforms.OSX | TestPlatforms.MacCatalyst;
protected const TestPlatforms CaseSensitivePlatforms = TestPlatforms.AnyUnix & ~TestPlatforms.OSX & ~TestPlatforms.MacCatalyst;

public static bool AreAllLongPathsAvailable => PathFeatures.AreAllLongPathsAvailable();

Expand Down Expand Up @@ -72,7 +72,7 @@ public static string GetNamedPipeServerStreamName()
string prefix = Path.Combine(Path.GetTempPath(), "CoreFxPipe_");
int availableLength = MinUdsPathLength - prefix.Length - 1; // 1 - for possible null terminator
Assert.True(availableLength >= MinAvailableForSufficientRandomness, $"UDS prefix {prefix} length {prefix.Length} is too long");

return string.Create(availableLength, 0, (span, _) =>
{
for (int i = 0; i < span.Length; i++)
Expand Down