Skip to content

Adding unit test for ScopeDisposed tracing event in DI #57591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
eerhardt merged 1 commit into from
Aug 19, 2021
Merged

Adding unit test for ScopeDisposed tracing event in DI #57591

eerhardt merged 1 commit into from
Aug 19, 2021

Conversation

@allantargino
Copy link
Contributor

@allantargino allantargino commented Aug 17, 2021 •
edited
Loading

Adds a missing test for ScopeDisposed tracing event in Dependency Injection extension.

The event was introduced in #51163, but I am using #56809 test conventions.

@ghost ghost added community-contribution Indicates that the PR has been added by a community member area-Extensions-DependencyInjection labels Aug 17, 2021
@ghost
Copy link

ghost commented Aug 17, 2021

Tagging subscribers to this area: @eerhardt, @maryamariyan
See info in area-owners.md if you want to be subscribed.

Issue Details

Adds a missing test for ScopeDisposed tracing event in Dependency Injection extension.

The feature was introduced in #51163, but I am using #56809 test conventions.

Author: allantargino
Assignees: -
Labels:

area-Extensions-DependencyInjection, community-contribution
Milestone: -

@dnfadmin
Copy link

dnfadmin commented Aug 17, 2021 •
edited
Loading

CLA assistant check
All CLA requirements met.

@allantargino allantargino changed the title Missing test for ScopeDisposed in DI tracing event Adding test for ScopeDisposed in DI tracing event Aug 18, 2021
@allantargino allantargino changed the title Adding test for ScopeDisposed in DI tracing event Adding unit test for ScopeDisposed tracing event in DI Aug 18, 2021
eerhardt
eerhardt approved these changes Aug 19, 2021
View reviewed changes
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@eerhardt eerhardt merged commit f3b77e6 into dotnet:main Aug 19, 2021
@allantargino allantargino deleted the issue-56313-di-test-event branch August 24, 2021 20:13
@ghost ghost locked as resolved and limited conversation to collaborators Sep 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@eerhardt eerhardt eerhardt approved these changes

Assignees

No one assigned

Labels

area-Extensions-DependencyInjection community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@allantargino @dnfadmin @eerhardt