Skip to content

[main] WasmAppBuilder: Use $(CopyLocalLockFileAssemblies) instead of … #59181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
radical merged 3 commits into from
Sep 16, 2021
Merged

[main] WasmAppBuilder: Use $(CopyLocalLockFileAssemblies) instead of … #59181

radical merged 3 commits into from
Sep 16, 2021

Conversation

@radical
Copy link
Member

@radical radical commented Sep 15, 2021 •
edited
Loading

.. explcitly invoking Publish.

Based on @ericstj's suggestion
#58816 (comment) .

Cherry pick 4d2eab4

@radical
[release/6.0][wasm] Add support for native relinking after Build, and…
00859ec 
… AOT after publish (dotnet#58913)

(cherry picked from commit f38d58f)
@radical
[release/6.0] WasmAppBuilder: publish only once per target framework …
6111988 
…instead of invoking publish explicitly. (dotnet#59136)

(cherry picked from commit 5d03338)
@ghost
Copy link

ghost commented Sep 15, 2021

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@radical radical added arch-wasm WebAssembly architecture area-Build-mono labels Sep 15, 2021
@ghost
Copy link

ghost commented Sep 15, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details 
[release/6.0][wasm] Add support for native relinking after Build, and… 
… AOT after publish (#58913)

(cherry picked from commit f38d58f1b1abc1b2c394481236f5cbcaaaf24545)

[release/6.0] WasmAppBuilder: publish only once per target framework …
…instead of invoking publish explicitly.

(cherry picked from commit 5d03338)
Author: radical
Assignees: -
Labels:

arch-wasm, area-Build-mono
Milestone: -

@radical radical requested a review from lewing September 15, 2021 19:01
@radical radical changed the title Cherry pick recent fixes from release/6.0 [wasm] Cherry pick recent changes from release/6.0 Sep 15, 2021
@radical radical requested a review from ericstj September 15, 2021 19:43
ericstj
ericstj approved these changes Sep 15, 2021
View reviewed changes
Copy link
Member

@ericstj ericstj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed 6111988 and it looks ok. Can't comment on the other commit.

@radical
Revert "[release/6.0][wasm] Add support for native relinking after Bu…
d971336 
…ild, and AOT after publish (dotnet#58913)"

This reverts commit 00859ec.

This will be ported in a separate PR.
@radical radical changed the title [wasm] Cherry pick recent changes from release/6.0 [wasm] Cherry pick recent fix from release/6.0 Sep 15, 2021
@radical
Copy link
Member Author

radical commented Sep 15, 2021

I reverted the other cherry picked commit, so this can go in sooner. The other one should get tested with some net7.0 changes for main.

@radical radical changed the title [wasm] Cherry pick recent fix from release/6.0 [main] WasmAppBuilder: publish only once per target framework … Sep 15, 2021
@radical radical requested a review from steveisok September 15, 2021 20:01
@ericstj ericstj mentioned this pull request Sep 15, 2021
Merged
@radical radical changed the title [main] WasmAppBuilder: publish only once per target framework … [main] WasmAppBuilder: Use $(CopyLocalLockFileAssemblies) instead of … Sep 16, 2021
@radical radical merged commit b7b8ef8 into dotnet:main Sep 16, 2021
@radical radical deleted the forward-port-main branch September 16, 2021 01:21
@ghost ghost locked as resolved and limited conversation to collaborators Nov 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ericstj ericstj ericstj approved these changes

@marek-safar marek-safar Awaiting requested review from marek-safar

@lewing lewing Awaiting requested review from lewing

@steveisok steveisok Awaiting requested review from steveisok

Assignees

No one assigned

Labels

arch-wasm WebAssembly architecture area-Build-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@radical @ericstj