Skip to content

Conversation

@kg
Copy link
Member

@kg kg commented Oct 14, 2021

Somewhat recently the module probing logic started passing null to g_path_get_dirname in some cases. While this wouldn't crash, it would print an error to the console.

cc @lambdageek

@kg kg added the arch-wasm WebAssembly architecture label Oct 14, 2021
@ghost
Copy link

ghost commented Oct 14, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Somewhat recently the module probing logic started passing null to g_path_get_dirname in some cases. While this wouldn't crash, it would print an error to the console.

cc @lambdageek

Author: kg
Assignees: -
Labels:

arch-wasm

Milestone: -

Copy link
Member

@lambdageek lambdageek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit1: indentation

nit2: (I realize this was on the old version - we should clean it up) a & b && c is kind of sus. (a & b) != 0 && c is better.

Co-authored-by: Aleksey Kliger (λgeek) <akliger@gmail.com>
@kg kg merged commit 027ea7f into dotnet:main Oct 15, 2021
@pavelsavara
Copy link
Member

Does this fix #60392 ?

@ilonatommy
Copy link
Member

Fixes #60392

@lewing
Copy link
Member

lewing commented Apr 12, 2023

/backport to release/6.0-staging

@github-actions github-actions bot unlocked this conversation Apr 12, 2023
@github-actions
Copy link
Contributor

Started backporting to release/6.0-staging: https://github.com/dotnet/runtime/actions/runs/4683579945

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants