Skip to content

Fix GCC warnings in test build #60734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
davmason merged 3 commits into from
Oct 22, 2021
Merged

Fix GCC warnings in test build #60734

davmason merged 3 commits into from
Oct 22, 2021

Conversation

@davmason
Copy link
Contributor

@davmason davmason commented Oct 21, 2021

No description provided.

@davmason davmason self-assigned this Oct 21, 2021
@ghost
Copy link

ghost commented Oct 21, 2021

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: davmason
Assignees: davmason
Labels:

area-Diagnostics-coreclr
Milestone: -

@davmason
Copy link
Contributor Author

davmason commented Oct 21, 2021

/azp run runtime-coreclr GCC Product Build Linux x64 checked

@azure-pipelines
Copy link

azure-pipelines bot commented Oct 21, 2021

No pipelines are associated with this pull request.

@davmason
Copy link
Contributor Author

davmason commented Oct 21, 2021

@hoyosjs or @am11, how do I trigger the failing GCC leg on this PR?

@am11
Copy link
Member

am11 commented Oct 21, 2021 •
edited
Loading

You can cherry-pick my commit from #60738. cc @safern
(or make a whitespace change under src/coreclr as a workaround)

am11
am11 reviewed Oct 21, 2021
View reviewed changes
Copy link
Member

@am11 am11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gcc leg is green here, I'll go ahead and close #60738. Thanks. 👍

@am11 am11 mentioned this pull request Oct 21, 2021
Closed
@davmason
Copy link
Contributor Author

davmason commented Oct 21, 2021

Adding infrastructure people since the infra changes are over here now

BruceForstall
BruceForstall approved these changes Oct 21, 2021
View reviewed changes
Copy link
Contributor

@BruceForstall BruceForstall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@runfoapp runfoapp bot mentioned this pull request Oct 21, 2021
Open
safern
safern approved these changes Oct 22, 2021
View reviewed changes
Copy link
Member

@safern safern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davmason
Copy link
Contributor Author

davmason commented Oct 22, 2021

I don't see how the failing libraries leg can be related, since this is fixing another failing leg I'm going to merge now

@davmason davmason merged commit 565f3ee into dotnet:main Oct 22, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Nov 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkoritzinsky jkoritzinsky jkoritzinsky approved these changes

@hoyosjs hoyosjs hoyosjs approved these changes

@safern safern safern approved these changes

+2 more reviewers

@am11 am11 am11 left review comments

@BruceForstall BruceForstall BruceForstall approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@davmason davmason

Labels

area-Diagnostics-coreclr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@davmason @am11 @jkoritzinsky @BruceForstall @hoyosjs @safern