Skip to content

Fix GCC warnings in test build #60734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davmason merged 3 commits into from
Oct 22, 2021
Merged

Fix GCC warnings in test build #60734

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1ebc905
fix warnings
davmason Oct 21, 2021
98824e4
Trigger GCC leg when src/tests is modified
am11 Oct 21, 2021
1ceb34d
Add src/native in default paths
am11 Oct 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions eng/pipelines/common/evaluate-default-paths.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ jobs:
- src/libraries/System.Private.CoreLib/*
- src/libraries/Native/Unix/System.Globalization.Native/*
- src/libraries/Native/Unix/Common/*
- src/native/*
exclude:
- eng/Version.Details.xml
- '*.md'
Expand All @@ -31,6 +32,7 @@ jobs:
- src/libraries/Native/Unix/System.Globalization.Native/*
- src/libraries/Native/Unix/Common/*
- src/tests/BuildWasmApps/*
- src/native/*
exclude:
- eng/Version.Details.xml
- '*.md'
Expand Down
1 change: 1 addition & 0 deletions eng/pipelines/runtime.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@ jobs:
condition: >-
or(
eq(dependencies.evaluate_paths.outputs['SetPathVars_coreclr.containsChange'], true),
eq(dependencies.evaluate_paths.outputs['SetPathVars_runtimetests.containsChange'], true),
eq(variables['isFullMatrix'], true))

#
Expand Down
4 changes: 2 additions & 2 deletions src/tests/profiler/native/eltprofiler/slowpatheltprofiler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,12 @@ using std::atomic;

shared_ptr<SlowPathELTProfiler> SlowPathELTProfiler::s_profiler;

#define PROFILER_STUB static void STDMETHODCALLTYPE

#ifndef WIN32
#define UINT_PTR_FORMAT "lx"
#define PROFILER_STUB __attribute__((visibility("hidden"))) static void STDMETHODCALLTYPE
#else // WIN32
#define UINT_PTR_FORMAT "llx"
#define PROFILER_STUB static void STDMETHODCALLTYPE
#endif // WIN32

PROFILER_STUB EnterStub(FunctionIDOrClientID functionId, COR_PRF_ELT_INFO eltInfo)
Expand Down
4 changes: 2 additions & 2 deletions src/tests/profiler/native/inlining/inlining.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,12 @@ using std::atomic;

shared_ptr<InliningProfiler> InliningProfiler::s_profiler;

#define PROFILER_STUB static void STDMETHODCALLTYPE

#ifndef WIN32
#define UINT_PTR_FORMAT "lx"
#define PROFILER_STUB __attribute__((visibility("hidden"))) static void STDMETHODCALLTYPE
#else // WIN32
#define UINT_PTR_FORMAT "llx"
#define PROFILER_STUB static void STDMETHODCALLTYPE
#endif // WIN32

PROFILER_STUB EnterStub(FunctionIDOrClientID functionId, COR_PRF_ELT_INFO eltInfo)
Expand Down