Skip to content

[PERF][MAUI] Update maui iOS build sed command #67263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
LoopedBard3 wants to merge 32 commits into from
Closed

[PERF][MAUI] Update maui iOS build sed command #67263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
dbe430b
Prepare for testing.
LoopedBard3 Mar 28, 2022
4830c36
Updated sed and moved maccatalyst to before ios build where the macca…
LoopedBard3 Mar 28, 2022
4b0f4bc
See if the sed worked properly and is what is causing the error.
LoopedBard3 Mar 28, 2022
9adc73b
Try line without escapes.
LoopedBard3 Mar 28, 2022
51cf19c
Specify the expression and the file explicitly.
LoopedBard3 Mar 29, 2022
a4e3034
Revert "Try line without escapes."
LoopedBard3 Mar 29, 2022
6a4fa02
Don't use -f for the file.
LoopedBard3 Mar 29, 2022
69a44af
Try adding /g and add an echo of the command.
LoopedBard3 Mar 29, 2022
2049cf4
Disable runtime build and try multiple sed lines to figure out what i…
LoopedBard3 Mar 31, 2022
ca1b32a
Remove -i for echo testing.
LoopedBard3 Apr 4, 2022
490f4dc
Remove second -i for echo input.
LoopedBard3 Apr 4, 2022
25d70e3
See if there are any hidden characters.
LoopedBard3 Apr 4, 2022
c9fc230
Change cat -vA to cat -vET
LoopedBard3 Apr 4, 2022
119c9ca
Add format-hex of the mauitesting.csproj file to see if there are wei…
LoopedBard3 Apr 4, 2022
bc872f5
MauiVersion doesn't exist atm.
LoopedBard3 Apr 4, 2022
2ba42c5
Try the sed earlier and what not.
LoopedBard3 Apr 4, 2022
3041779
Fix spacing issue.
LoopedBard3 Apr 4, 2022
5cdd3b9
Fix for real?
LoopedBard3 Apr 4, 2022
f94dfb6
Revert "Fix for real?"
LoopedBard3 Apr 4, 2022
c9a43ae
Another attempt...
LoopedBard3 Apr 4, 2022
c621a36
Back to incremental testing.
LoopedBard3 Apr 4, 2022
9714884
Add g to change all
LoopedBard3 Apr 4, 2022
c092c94
Add a bunch of test cases.
LoopedBard3 Apr 4, 2022
1535fee
Next iteration.
LoopedBard3 Apr 4, 2022
336dd3c
Another iteration...
LoopedBard3 Apr 4, 2022
a632f3e
Iteration 3?
LoopedBard3 Apr 4, 2022
3fda89a
Add extended regex and fix incorrect grouping number.
LoopedBard3 Apr 5, 2022
0af9a9c
Iteration 5?
LoopedBard3 Apr 5, 2022
307dcf7
Final testing iter?
LoopedBard3 Apr 5, 2022
98cbb6e
Change script to bash.
LoopedBard3 Apr 5, 2022
f7154d5
More file sed testing.
LoopedBard3 Apr 5, 2022
279476a
Add missing backslashes.
LoopedBard3 Apr 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 14 additions & 9 deletions eng/pipelines/common/global-build-job.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,9 +117,14 @@ jobs:
- ${{ variable }}

steps:
- checkout: self
clean: true
fetchDepth: $(checkoutFetchDepth)
#- checkout: self
# clean: true
# fetchDepth: $(checkoutFetchDepth)

- bash: |
echo echo "'<TargetFrameworks>net6.0-android;net6.0-ios;net6.0-maccatalyst</TargetFrameworks>' | sed -E -e 's/([>;])net[0-9]+\.[0-9]+-maccatalyst([<;])/\1\2/g'"
echo '<TargetFrameworks>net6.0-android;net6.0-ios;net6.0-maccatalyst</TargetFrameworks>' | sed -E -e 's/([>;])net[0-9]+\.[0-9]+-maccatalyst([<;])/\1\2/g'
displayName: SEDTesting

- ${{ if eq(parameters.isOfficialBuild, true) }}:
- template: /eng/pipelines/common/restore-internal-tools.yml
Expand Down Expand Up @@ -154,12 +159,12 @@ jobs:
inputs:
filePath: $(Build.SourcesDirectory)/eng/pipelines/mono/update-machine-certs.ps1

# Build
- ${{ if eq(parameters.buildingOnSourceBuildImage, false) }}:
- script: $(_sclEnableCommand) $(Build.SourcesDirectory)$(dir)build$(scriptExt) -ci -arch ${{ parameters.archType }} $(_osParameter) ${{ parameters.buildArgs }} $(_officialBuildParameter) $(_crossBuildPropertyArg) $(_cxx11Parameter) $(_richCodeNavigationParam) $(_buildDarwinFrameworksParameter)
displayName: Build product
${{ if eq(parameters.useContinueOnErrorDuringBuild, true) }}:
continueOnError: ${{ parameters.shouldContinueOnError }}
## Build
#- ${{ if eq(parameters.buildingOnSourceBuildImage, false) }}:
# - script: $(_sclEnableCommand) $(Build.SourcesDirectory)$(dir)build$(scriptExt) -ci -arch ${{ parameters.archType }} $(_osParameter) ${{ parameters.buildArgs }} $(_officialBuildParameter) $(_crossBuildPropertyArg) $(_cxx11Parameter) $(_richCodeNavigationParam) $(_buildDarwinFrameworksParameter)
# displayName: Build product
# ${{ if eq(parameters.useContinueOnErrorDuringBuild, true) }}:
# continueOnError: ${{ parameters.shouldContinueOnError }}

- ${{ if in(parameters.osGroup, 'OSX', 'iOS', 'tvOS', 'Android') }}:
- script: |
Expand Down
Loading