Fix system IO ports native dependency for package testing #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Wasn't there a newer version produced in corefx? Tomas committed a fix in corefx. If yes, I would prefer to use that version. |
Member
Author
I checked, but since the channels were already disabled, it didn't publish it to the blob feed. That was what I intended to do 😄 |
ViktorHofer
approved these changes
Nov 16, 2019
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #63
We can't update this version until we produce a new package from the runtime repository.
For package testing we depend on a static version of runtime.native.System.IO.Ports package which is gotten through the version in Versions.props updated by BAR. The problem is that we're depending on a version which contains the freebsd RID in it's dependencies since that was the last BAR update we got from corefx and we're no longer updating that version. So I downgraded it and it is fixed.