Add the capability to walk up the inheritance chain for GetMemberWithSameMetadataDefinitionAs#69057
Merged
LakshanF merged 2 commits intodotnet:mainfrom May 9, 2022
Merged
Conversation
|
Tagging subscribers to this area: @dotnet/area-system-reflection Issue DetailsIssue #67533 has a scenario where a
|
LakshanF
changed the title
jkotas
reviewed
May 9, 2022
Member
|
Look for |
jkotas
reviewed
May 9, 2022
Member
|
This appears to have introduced #69136 |
Member
|
I opened a pr to verify, feel free to resolve it some other way |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #67533 has a scenario where a
MemberInfois in the parent of a type andnativeAOTfails forGetMemberWithSameMetadataDefinitionAssince it only checks the current type. The fix is to walk up the chain leveraging the existing caching mechanism.