Remove unneeded unconditional jumps for Arm/Arm64 #70389
Conversation
jit format changes bug fixes Arm fixes
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
src/coreclr/jit/emit.cpp
Outdated
| instrDescJmp* nextJmp = jmp->idjNext; | ||
|
|
||
| if (jmp->idInsFmt() == IF_LABEL && emitIsUncondJump(jmp) && jmp->idjIsRemovableJmpCandidate) | ||
| if (emitIsUncondJump(jmp) && jmp->idjIsRemovableJmpCandidate) |
There was a problem hiding this comment.
You need the IF_LABEL check because it will assert on XARCH if an lea is present in the jump list and is passed to emitIsUncondJump
There was a problem hiding this comment.
Ah ok. Let me put it back.
kunalspathak
changed the title
| #ifdef TARGET_XARCH | ||
| instruction jmpInstr = INS_jmp; | ||
| #else // TARGET_ARM64 | ||
| instruction jmpInstr = INS_b; | ||
| #endif |
There was a problem hiding this comment.
Won't the assumption that it's either ARM or XARCH be invalid on LoongArch64 builds?
There was a problem hiding this comment.
they will be and I need to do fix/validate it. This is draft and I would like to get a sense of its state before I spend time on other archs.
|
As expected, Arm needs some more fixes, will do it when I get a chance. |
ghost
closed this
|
Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it. |
ghost
locked as resolved and limited conversation to collaborators
3 participants
Extend #69041 for Arm/Arm64.
cc: @Wraith2