Skip to content

Conversation

@kunalspathak
Copy link
Contributor

For jumps that are injected in the prolog of initialization need to be handled inside emitDispJumpList().

Fixes: #71049

@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jun 21, 2022
@ghost ghost assigned kunalspathak Jun 21, 2022
@ghost
Copy link

ghost commented Jun 21, 2022

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

For jumps that are injected in the prolog of initialization need to be handled inside emitDispJumpList().

Fixes: #71049

Author: kunalspathak
Assignees: -
Labels:

area-CodeGen-coreclr

Milestone: -

@kunalspathak
Copy link
Contributor Author

@dotnet/jit-contrib

Copy link
Contributor

@BruceForstall BruceForstall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good for now.

We should probably add a helper to commonize/print jmp instrDescs. E.g., you could also print Bound ones, like the disasm code:

            if (id->idIsBound())
            {
                emitPrintLabel(id->idAddr()->iiaIGlabel);
            }
            else
            {
                printf("L_M%03u_" FMT_BB, emitComp->compMethodID, id->idAddr()->iiaBBlabel->bbNum);
            }

@kunalspathak
Copy link
Contributor Author

We should probably add a helper to commonize/print jmp instrDescs. E.g., you could also print Bound ones, like the disasm code:

This needs modification as part of #70389. Will do it at that time.

@kunalspathak kunalspathak merged commit ead19a3 into dotnet:main Jun 22, 2022
@kunalspathak kunalspathak deleted the jmplist branch June 22, 2022 04:36
@ghost ghost locked as resolved and limited conversation to collaborators Jul 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AVs in emitDispJumpList

2 participants