Skip to content

Add TieredPGO and ReadyToRun to Microsoft-Windows-DotNETRuntime/TieredCompilation/Settings event #72056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
eduardo-vp merged 18 commits into from
Aug 4, 2022
Merged

Add TieredPGO and ReadyToRun to Microsoft-Windows-DotNETRuntime/TieredCompilation/Settings event #72056

eduardo-vp merged 18 commits into from
Aug 4, 2022

Conversation

@eduardo-vp
Copy link
Member

@eduardo-vp eduardo-vp commented Jul 12, 2022

Fixes #69820

@ghost ghost assigned eduardo-vp Jul 12, 2022
@ghost ghost added the area-VM-coreclr label Jul 12, 2022
@eduardo-vp eduardo-vp requested a review from kouvel July 12, 2022 23:27
kouvel
kouvel reviewed Jul 13, 2022
View reviewed changes
kouvel
kouvel approved these changes Jul 13, 2022
View reviewed changes
Copy link
Contributor

@kouvel kouvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one suggestion, otherwise LGTM

jkotas
jkotas requested changes Jul 13, 2022
View reviewed changes
@ghost ghost added the needs-author-action An issue or pull request that requires more info or actions from the author. label Jul 13, 2022
@eduardo-vp eduardo-vp mentioned this pull request Jul 13, 2022
Merged
@ghost ghost removed the needs-author-action An issue or pull request that requires more info or actions from the author. label Jul 14, 2022
@eduardo-vp eduardo-vp requested a review from jkotas July 14, 2022 18:45
jkotas
jkotas reviewed Jul 14, 2022
View reviewed changes
jkotas
jkotas reviewed Jul 14, 2022
View reviewed changes
jkotas
jkotas reviewed Jul 14, 2022
View reviewed changes
jkotas
jkotas reviewed Jul 14, 2022
View reviewed changes
@eduardo-vp eduardo-vp marked this pull request as ready for review August 3, 2022 00:05
@eduardo-vp eduardo-vp requested review from jkotas and kouvel August 3, 2022 00:09
@eduardo-vp
Copy link
Member Author

eduardo-vp commented Aug 3, 2022

After the previous review, I set the value of ReadyToRun and TieredPGO before the event was fired (a bug of mine) and added a conditional on the ReadyToRun as the TieredPGO has one as well

jkotas
jkotas requested changes Aug 3, 2022
View reviewed changes
@ghost ghost added the needs-author-action An issue or pull request that requires more info or actions from the author. label Aug 3, 2022
@ghost ghost removed the needs-author-action An issue or pull request that requires more info or actions from the author. label Aug 3, 2022
kouvel
kouvel reviewed Aug 3, 2022
View reviewed changes
@eduardo-vp
Copy link
Member Author

eduardo-vp commented Aug 4, 2022

/azp run runtime

@azure-pipelines
Copy link

azure-pipelines bot commented Aug 4, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@eduardo-vp eduardo-vp merged commit 0c4db6e into dotnet:main Aug 4, 2022
@AndyAyersMS AndyAyersMS mentioned this pull request Aug 9, 2022
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Sep 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkotas jkotas jkotas approved these changes

+1 more reviewer

@kouvel kouvel kouvel approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@eduardo-vp eduardo-vp

Labels

area-VM-coreclr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

It is difficult to determine whether TieredPGO and ReadyToRun are enabled

3 participants

@eduardo-vp @jkotas @kouvel