Delete some unnecessary code #74527
Merged
Delete some unnecessary code #74527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsThree commits:
|
This was originally put in place to allow the corresponding codegen changes to be tested. Now that we have more than adequate coverage from the front-end transformations, we can simply delete the code.
We don't expect any OBJs here.
SingleAccretion
force-pushed
the
No-Obj-Folding
branch
from
39110ff to
146d259
Compare
Contributor
Author
|
@dotnet/jit-contrib |
Member
|
@kunalspathak can you review? |
Contributor
I am not much familiar with this code lately. Can you elaborate in PR comments why explicit simplification is not needed now? |
Contributor
Author
Essentially, we are now folding this pattern in local morph, and so don't need the additional checks. Eventually, almost all such checks will be deleted from the codebase; this is a start. |
SingleAccretion
commented
Sep 13, 2022
| { | ||
| if (m_dst->OperIs(GT_OBJ)) | ||
| { | ||
| GenTreeLclVar* lclVar = m_comp->fgMorphTryFoldObjAsLclVar(m_dst->AsObj()); |
|
|
||
| // First, handle the GT_OBJ case, which loads into the arg register | ||
| // (so we don't set the use to prefer that register for the source address). | ||
| if (op1->OperIs(GT_OBJ)) |
| #endif // !TARGET_X86 | ||
| } | ||
|
|
||
| if (src->OperIs(GT_OBJ) && src->AsObj()->Addr()->OperIsLocalAddr()) |
Contributor
Author
| // STRUCT args (FIELD_LIST / OBJ / LCL_VAR / LCL_FLD) will always be contained. | ||
| MakeSrcContained(putArgNode, src); | ||
|
|
||
| // TODO-ADDR: always perform this transformation in local morph and delete this code. |
Contributor
Author
Contributor
|
Great...thank you. I am not able to access the |
Contributor
Author
There are no diffs outside of
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three commits:
OBJ(ADDR(LCL_VAR))anymore. No diffs.Diffs.