SPMI: Avoid division by zero #76544
Merged
SPMI: Avoid division by zero #76544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the MinOpts/FullOpts split it is common/expected to see some of these being completely empty, and we hit DivisionByZero in those cases. Fix dotnet#76542
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsWith the MinOpts/FullOpts split it is common/expected to see some of these being completely empty, and we hit DivisionByZero in those cases. Fix #76542
|
Member
Author
|
Quoting from #76542 (comment):
|
Member
Author
|
cc @dotnet/jit-contrib PTAL @BruceForstall |
BruceForstall
approved these changes
Oct 3, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the MinOpts/FullOpts split it is common/expected to see some of these being completely empty, and we hit DivisionByZero in those cases.
Fix #76542