Skip to content

SPMI: Avoid division by zero #76544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jakobbotsch merged 1 commit into from
Oct 3, 2022
Merged

SPMI: Avoid division by zero #76544

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/coreclr/scripts/superpmi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2234,12 +2234,21 @@ def replay_with_throughput_diff(self):
# impacted collections and a detailed one that includes raw
# instruction count and all collections.
def is_significant_pct(base, diff):
if base == 0:
return diff != 0

return round((diff - base) / base * 100, 2) != 0

def is_significant(row, base, diff):
return is_significant_pct(int(base[row]["Diff executed instructions"]), int(diff[row]["Diff executed instructions"]))
def format_pct(base_instructions, diff_instructions):
plus_if_positive = "+" if diff_instructions > base_instructions else ""
text = "{}{:.2f}%".format(plus_if_positive, (diff_instructions - base_instructions) / base_instructions * 100)
if base_instructions > 0:
pct = (diff_instructions - base_instructions) / base_instructions * 100
else:
pct = 0.0

text = "{}{:.2f}%".format(plus_if_positive, pct)
if diff_instructions != base_instructions:
color = "red" if diff_instructions > base_instructions else "green"
return html_color(color, text)
Expand Down