[release/8.0] Check if loop body occured before loopTop and if so unmark alignment #91918
Conversation
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsBackport of #91854 to release/8.0 /cc @kunalspathak Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
There was a problem hiding this comment.
approved. please get a code review. once ready this can be merged.
|
This PR has an issue that needs to be addressed first: |
ghost
added
the
needs-author-action
ghost
removed
the
needs-author-action
|
@BruceForstall - Updated the PR with changes from #92132. @carlossanlop - we should wait to merge this PR only after #92132 has a green CI and is merged (in sometime). |
|
@carlossanlop - #92132 is merged. We can merge this PR as well. |
|
@kunalspathak @BruceForstall @jeffschwMSFT I'm confused: PR #92132 was merged to main, but this PR is for release/8.0. Do we need to backport #92132 before merging this? |
|
@carlossanlop This backport PR was already updated with the changes in #92132. So, this backport PR includes the changes from both PR #91854 as well as the follow-up PR #92132. |
|
Got it, I misunderstood. Merging now. |
Backport of #91854 to release/8.0
/cc @kunalspathak
Customer Impact
In some cases, we might falsely align loops that might adversely affect the performance. This PR fixes that problem.
Testing
Our CI includes the tests are they no longer fail with the fix. Also, manually verified that false loops are not marked as needs alignment.
Risk
Low because this happens in code having lot of loops and need lot of code motion to get this scenario triggered.
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.