Check if bbNatLoopNum is not NOT_IN_LOOP #92132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
Author
|
@dotnet/jit-contrib @BruceForstall |
BruceForstall
approved these changes
Sep 15, 2023
src/coreclr/jit/compiler.cpp
Outdated
| char buffer[50]; | ||
| sprintf_s(buffer, 50, "loop block " FMT_BB " appears before top of loop", | ||
| char buffer[100]; | ||
| sprintf_s(buffer, 80, "loop block " FMT_BB " appears before top of loop", |
Contributor
There was a problem hiding this comment.
why is this 80 instead of 100? (or sizeof(buffer))?
src/coreclr/jit/compiler.cpp
Outdated
| unmarkedLoopAlign = true; | ||
| } | ||
| else if (visitedLoopNum[loopTop->bbNatLoopNum]) | ||
| else if ((loopTop->bbNatLoopNum != BasicBlock::NOT_IN_LOOP) && (visitedLoopNum[loopTop->bbNatLoopNum])) |
Contributor
There was a problem hiding this comment.
Don't need so many parens
Suggested change
| else if ((loopTop->bbNatLoopNum != BasicBlock::NOT_IN_LOOP) && (visitedLoopNum[loopTop->bbNatLoopNum])) | |
| else if ((loopTop->bbNatLoopNum != BasicBlock::NOT_IN_LOOP) && visitedLoopNum[loopTop->bbNatLoopNum]) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to the fix I made in #91854.
Fixes: #91972