Separate copying of refs from preservation of compilation info#2800
Merged
Conversation
PreserveCompilationContext does two things today: 1. Write compilation info to .deps 2. Copy reference-only assemblies to build/publish refs/ folder Add PreserveCompilationReferences to control (2) independently and default it to PreserveCompilationContext for backwards compatibility.
livarcocc
approved these changes
Jan 8, 2019
pranavkm
approved these changes
Jan 8, 2019
dsplaisted
approved these changes
Jan 8, 2019
Member
dsplaisted
left a comment
dsplaisted
left a comment
There was a problem hiding this comment.
There are some Linux test failures, but otherwise this looks good. Perhaps the issue is the tests are targeting .NET Framework and aren't using the targeting pack packages?
Contributor
Author
|
Yeah, I thought there was no reason for the test I changed to be Windows only, but apparently there is. :) Looking into it. It seems to find the targeting pack, but then the ref to netstandard.dll does not kick in, so something wrong with extensions? |
wli3
pushed a commit
that referenced
this pull request
Feb 7, 2020
…build 20190910.11 (#2800) - Microsoft.NET.Sdk.Razor - 3.1.0-alpha1.19460.11
wli3
pushed a commit
that referenced
this pull request
Feb 7, 2020
…elease/3.1.1xx-to-master * upstream/release/3.1.1xx: (603 commits) [release/3.0.1xx] Update dependencies from microsoft/vstest (#2809) Update dependencies from https://github.com/dotnet/cli build 20190911.11 (#2823) Update dependencies from https://github.com/dotnet/cli build 20190911.7 (#2819) Update dependencies from https://github.com/dotnet/cli build 20190911.6 (#2818) Update dependencies from https://github.com/aspnet/websdk build 20190911.2 (#2816) Update dependencies from https://github.com/dotnet/arcade build 20190910.3 (#2815) Update dependencies from https://github.com/dotnet/cli build 20190911.1 (#2807) Update dependencies from https://github.com/dotnet/fsharp build 20190910.5 (#2804) Update dependencies from https://github.com/dotnet/cli build 20190910.6 (#2803) Update dependencies from https://github.com/aspnet/AspNetCore-Tooling build 20190910.13 (#2802) Update dependencies from https://github.com/aspnet/AspNetCore-Tooling build 20190910.12 (#2801) Update dependencies from https://github.com/aspnet/AspNetCore-Tooling build 20190910.11 (#2800) Update dependencies from https://github.com/dotnet/cli build 20190910.5 (#2799) Update dependencies from https://github.com/aspnet/websdk build 20190910.5 (#2798) Update dependencies from https://github.com/aspnet/AspNetCore-Tooling build 20190910.5 (#2797) Update dependencies from https://github.com/dotnet/arcade build 20190910.3 (#2796) Update dependencies from https://github.com/dotnet/cli build 20190910.4 (#2794) Update dependencies from https://github.com/aspnet/websdk build 20190910.4 (#2795) Update dependencies from https://github.com/aspnet/AspNetCore-Tooling build 20190910.3 (#2793) [release/3.0.1xx] Update dependencies from aspnet/AspNetCore-Tooling (#2759) ... Conflicts: eng/Version.Details.xml eng/Versions.props eng/common/native/install-cmake-test.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PreserveCompilationContext does two things today:
Add PreserveCompilationReferences to control (2) independently and default it to PreserveCompilationContext for backwards compatibility.
Fix #2122
cc @pranavkm @rynowak @eerhardt