Limit default apphost feature to netcoreapp3.0 targeted apps.#2816
Merged
Conversation
nguerrera
approved these changes
Jan 12, 2019
This commit limits the default apphost feature to applications that target `netcoreapp3.0` or later. This prevents altering the expected outputs of previous projects after an upgrade to a 3.0 SDK. More importantly, this allows for the removal of the hack that was put in place to force a restore of the SDK RID to obtain the apphost; the apphost is now resolved through framework references. Fixes dotnet/cli#10566.
peterhuene
force-pushed
the
limit-default-apphost
branch
from
67c4c08 to
06d624f
Compare
wli3
pushed a commit
that referenced
this pull request
Feb 7, 2020
…911.2 (#2816) - Microsoft.NET.Sdk.Web - 3.0.100-rc2.19461.2
wli3
pushed a commit
that referenced
this pull request
Feb 7, 2020
…elease/3.0.1xx-to-release/3.1.1xx * upstream/release/3.0.1xx: (231 commits) [release/3.0.1xx] Update dependencies from microsoft/vstest (#2809) Update dependencies from https://github.com/dotnet/cli build 20190911.11 (#2823) Update dependencies from https://github.com/aspnet/websdk build 20190911.2 (#2816) Update dependencies from https://github.com/dotnet/cli build 20190911.1 (#2807) Update dependencies from https://github.com/dotnet/cli build 20190910.6 (#2803) Update dependencies from https://github.com/aspnet/AspNetCore-Tooling build 20190910.12 (#2801) Update dependencies from https://github.com/dotnet/cli build 20190910.5 (#2799) Update dependencies from https://github.com/aspnet/websdk build 20190910.5 (#2798) Update dependencies from https://github.com/aspnet/AspNetCore-Tooling build 20190910.5 (#2797) Update dependencies from https://github.com/dotnet/arcade build 20190910.3 (#2796) Update dependencies from https://github.com/dotnet/cli build 20190910.4 (#2794) Update dependencies from https://github.com/aspnet/websdk build 20190910.4 (#2795) [release/3.0.1xx] Update dependencies from aspnet/AspNetCore-Tooling (#2759) Update dependencies from https://github.com/aspnet/websdk build 20190910.2 (#2792) Update dependencies from https://github.com/dotnet/core-setup build 20190910.02 Update dependencies from https://github.com/dotnet/arcade build 20190909.10 (#2788) Update dependencies from https://github.com/dotnet/core-setup build 20190909.40 (#2781) Update dependencies from https://github.com/Microsoft/msbuild build 20190906.2 (#2779) Update dependencies from https://github.com/dotnet/core-setup build 20190909.33 (#2775) Update dependencies from https://github.com/dotnet/cli build 20190909.10 (#2771) ... Conflicts: eng/Version.Details.xml eng/Versions.props
wli3
pushed a commit
that referenced
this pull request
Feb 7, 2020
…elease/3.1.1xx-to-master * upstream/release/3.1.1xx: (603 commits) [release/3.0.1xx] Update dependencies from microsoft/vstest (#2809) Update dependencies from https://github.com/dotnet/cli build 20190911.11 (#2823) Update dependencies from https://github.com/dotnet/cli build 20190911.7 (#2819) Update dependencies from https://github.com/dotnet/cli build 20190911.6 (#2818) Update dependencies from https://github.com/aspnet/websdk build 20190911.2 (#2816) Update dependencies from https://github.com/dotnet/arcade build 20190910.3 (#2815) Update dependencies from https://github.com/dotnet/cli build 20190911.1 (#2807) Update dependencies from https://github.com/dotnet/fsharp build 20190910.5 (#2804) Update dependencies from https://github.com/dotnet/cli build 20190910.6 (#2803) Update dependencies from https://github.com/aspnet/AspNetCore-Tooling build 20190910.13 (#2802) Update dependencies from https://github.com/aspnet/AspNetCore-Tooling build 20190910.12 (#2801) Update dependencies from https://github.com/aspnet/AspNetCore-Tooling build 20190910.11 (#2800) Update dependencies from https://github.com/dotnet/cli build 20190910.5 (#2799) Update dependencies from https://github.com/aspnet/websdk build 20190910.5 (#2798) Update dependencies from https://github.com/aspnet/AspNetCore-Tooling build 20190910.5 (#2797) Update dependencies from https://github.com/dotnet/arcade build 20190910.3 (#2796) Update dependencies from https://github.com/dotnet/cli build 20190910.4 (#2794) Update dependencies from https://github.com/aspnet/websdk build 20190910.4 (#2795) Update dependencies from https://github.com/aspnet/AspNetCore-Tooling build 20190910.3 (#2793) [release/3.0.1xx] Update dependencies from aspnet/AspNetCore-Tooling (#2759) ... Conflicts: eng/Version.Details.xml eng/Versions.props eng/common/native/install-cmake-test.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit limits the default apphost feature to applications that target
netcoreapp3.0or later.This prevents altering the expected outputs of previous projects after an
upgrade to a 3.0 SDK.
More importantly, this allows for the removal of the hack that was put in place
to force a restore of the SDK RID to obtain the apphost; the apphost is now
resolved through framework references.
Fixes dotnet/cli#10566.