[release/7.0.1xx] Reference net7.0 version of msbuild for source-build#28425
Merged
lbussell merged 1 commit intodotnet:release/7.0.1xxfrom Oct 11, 2022
Merged
[release/7.0.1xx] Reference net7.0 version of msbuild for source-build#28425lbussell merged 1 commit intodotnet:release/7.0.1xxfrom
lbussell merged 1 commit intodotnet:release/7.0.1xxfrom
Conversation
lbussell
requested review from
MichaelSimons,
benvillalobos,
crummel,
dsplaisted and
rainersigwald
ghost
added
the
lbussell
changed the title
MichaelSimons
approved these changes
Oct 10, 2022
crummel
approved these changes
Oct 10, 2022
Member
Author
|
@rainersigwald or @dsplaisted, can someone from the SDK or MSBuild teams review this so that this can make it into 7.0 GA? Thanks in advance. |
dsplaisted
approved these changes
Oct 11, 2022
rainersigwald
approved these changes
Oct 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/source-build#3048
Backport of this source-build patch: https://github.com/dotnet/installer/blob/860067bade6be3fbda19a3162abde99286c82df1/src/SourceBuild/tarball/patches/sdk/0002-Look-for-msbuild-net7.0-artifacts.patch
We changed msbuild to target net7.0 but we still need to use an older version (17.3.0 in this case) in the Microsoft-built SDK for VS and VS for Mac compatibility. This means we need a couple of source-build conditions for this change. The change to
MicrosoftBuildPackageVersiononly affects the repo's source-build CI leg and not the source-build tarball build.