Enable is shipping package in the installer redist to stabilize branding of the installers#44289
Merged
marcpopMSFT merged 1 commit intorelease/9.0.1xxfrom Oct 18, 2024
Merged
Conversation
…ing of the installers
ghost
added
mmitche
approved these changes
Oct 17, 2024
This was referenced Oct 18, 2024
Member
|
@marcpopMSFT - Why was this merged with a failing SB CI leg? This introduced a regression - dotnet/source-build#4682. |
Member
Author
|
I saw the failing test in the SDK build and identified it as a known issue. I missed that source build was also failing when I merged. My mistake. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Arcade defaults this value to true and the installer repo didn't set it for any of the .csproj files. The SDK repo defaults it to false in the directory.build.props.
Reviewing what files are stable branded versus not in 8 and 9, I think it's the installers that are off. The rest of the csproj files from installer aren't building packages that actually ship so I don't think any of the rest of the projects require this. Doing a test AzDO build to see.