Skip to content

[release/9.0.1xx] Update dependencies from dotnet/msbuild#44299

Merged
marcpopMSFT merged 4 commits intorelease/9.0.1xxfrom
darc-release/9.0.1xx-0de3bb13-4b69-4170-8690-7913fba1f701
Oct 21, 2024
Merged

[release/9.0.1xx] Update dependencies from dotnet/msbuild#44299
marcpopMSFT merged 4 commits intorelease/9.0.1xxfrom
darc-release/9.0.1xx-0de3bb13-4b69-4170-8690-7913fba1f701

Conversation

@dotnet-maestro
Copy link
Copy Markdown
Contributor

@dotnet-maestro dotnet-maestro Bot commented Oct 18, 2024 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/msbuild

  • Subscription: 5dbc3253-3d65-4bc6-0a53-08dcbc302537
  • Build: 20241018.5
  • Date Produced: October 18, 2024 7:37:15 PM UTC
  • Commit: db5f6012cb7f6e2dd7066c50c573c0d352713407
  • Branch: refs/heads/vs17.12

@dotnet-maestro
Update dependencies from https://github.com/dotnet/msbuild build 2024…
26ee292 
…1017.6

Microsoft.SourceBuild.Intermediate.msbuild , Microsoft.Build , Microsoft.Build.Localization
 From Version 17.12.3-preview-24504-01 -> To Version 17.12.5-preview-24517-06
@ghost ghost added Area-Infrastructure untriaged Request triage from a team member labels Oct 18, 2024
@marcpopMSFT marcpopMSFT requested review from a team as code owners October 18, 2024 17:30
@marcpopMSFT
Copy link
Copy Markdown
Member

marcpopMSFT commented Oct 18, 2024

@dotnet/source-build it looks like the VerifyVersionFile test doesn't like that we switched to stable versioning. The test seems off here as the product looks right to me with a stable version on line [1] of .version and unstable on line [3]

@ellahathaway
Copy link
Copy Markdown
Member

ellahathaway commented Oct 18, 2024 •
edited
Loading

@dotnet/source-build it looks like the VerifyVersionFile test doesn't like that we switched to stable versioning. The test seems off here as the product looks right to me with a stable version on line [1] of .version and unstable on line [3]

This was caused by #44289 being merged on red. The PR shows that the version test was failing.

Filed dotnet/source-build#4682 in response.

@dotnet-maestro
Update dependencies from https://github.com/dotnet/msbuild build 2024…
e4bbfbf 
…1018.5

Microsoft.SourceBuild.Intermediate.msbuild , Microsoft.Build , Microsoft.Build.Localization
 From Version 17.12.5-preview-24517-06 -> To Version 17.12.6-preview-24518-05
@build-analysis build-analysis Bot mentioned this pull request Oct 19, 2024
Open
Merge branch 'release/9.0.1xx' of https://github.com/dotnet/sdk into …
1852b61 
…darc-release/9.0.1xx-0de3bb13-4b69-4170-8690-7913fba1f701
@marcpopMSFT
Copy link
Copy Markdown
Member

marcpopMSFT commented Oct 21, 2024

This was caused by #44289 being merged on red. The PR shows that the version test was failing.

Filed dotnet/source-build#4682 in response.

Dang, I saw the test failure in the other PR and since it was a known issue, merged anyway but missed that source build was also failing. My mistake.

@marcpopMSFT
Copy link
Copy Markdown
Member

marcpopMSFT commented Oct 21, 2024

Source build failures is in the branch already and tracked separately so merging on red.

@marcpopMSFT marcpopMSFT merged commit 2ea3a8c into release/9.0.1xx Oct 21, 2024
@marcpopMSFT marcpopMSFT deleted the darc-release/9.0.1xx-0de3bb13-4b69-4170-8690-7913fba1f701 branch October 21, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mmitche mmitche mmitche approved these changes

Assignees

No one assigned

Labels

Area-CodeFlow untriaged Request triage from a team member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marcpopMSFT @ellahathaway @mmitche