[ApiDiff] Add static factory method to generate AssemblySymbolLoader#46380
Merged
carlossanlop merged 4 commits intodotnet:mainfrom Jan 31, 2025
carlossanlop:AssemblySymbolLoader
Merged
[ApiDiff] Add static factory method to generate AssemblySymbolLoader#46380carlossanlop merged 4 commits intodotnet:mainfrom carlossanlop:AssemblySymbolLoader
carlossanlop merged 4 commits intodotnet:mainfrom
carlossanlop:AssemblySymbolLoader
Conversation
ghost
added
Extract the document generation logic into its own class. Refactor GenAPIApp and GenApiTask to generate a loader using the static method.
ViktorHofer
reviewed
Jan 30, 2025
ViktorHofer
reviewed
Jan 30, 2025
carlossanlop
commented
Jan 30, 2025
carlossanlop
commented
Jan 30, 2025
carlossanlop
commented
Jan 30, 2025
…bol Loader instance inside it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up of #46255
This PR is part of the work needed to create an ApiDiff tool that reuses some of the code from Microsoft.DotNet.GenAPI. The idea is to make the larger PR smaller and make it easier to review: #45389
The proposed changes in this PR include: