[GenAPI] Fix header handling in GenAPI and CSharpFileBuilder#46534
Merged
carlossanlop merged 3 commits intodotnet:mainfrom Feb 5, 2025
carlossanlop:FixHeaderGenAPI
Merged
[GenAPI] Fix header handling in GenAPI and CSharpFileBuilder#46534carlossanlop merged 3 commits intodotnet:mainfrom carlossanlop:FixHeaderGenAPI
carlossanlop merged 3 commits intodotnet:mainfrom
carlossanlop:FixHeaderGenAPI
Conversation
…. All other tests are using empty string.
michaelgsharp
approved these changes
Feb 4, 2025
MichaelSimons
approved these changes
Feb 4, 2025
ViktorHofer
approved these changes
Feb 5, 2025
Contributor
Author
|
/ba-g failures are unrelated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix the bug reported in dotnet/source-build-assets#1131
#46380 introduced a regression in GenAPI preventing the correct loading of the header file when specified. The modified code was assuming the passed string was the contents of the header, but in reality it was the header file path.
The fix consists in reading the contents of the file path in GenAPIApp and then pass that string to CSharpFileBuilder instead.
I also noticed we didn't have any tests to verify different headers, so I added a couple:
cc @MichaelSimons