Fix .gitignore test failure & build error(s)#54067
Merged
MiYanni merged 6 commits intodotnet:mainfrom Apr 26, 2026
Merged
Conversation
…e_feed folder to those required for CI to run.
nagilson
approved these changes
Apr 24, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the dotnet-gitignore-file template approval test after .lscache was added to the gitignore template, and ensures PR CI runs when template feed content changes.
Changes:
- Update the
dotnet-gitignore-fileapproval.gitignoreto include*.lscache. - Update
.vsts-pr.ymlPR path filters to includetemplate_feed/so CI triggers on template updates.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/dotnet-new.IntegrationTests/Approvals/AllCommonItemsCreate.-o#dotnet-gitignore-file#-n#item.verified/dotnet-gitignore-file/.gitignore | Updates the approved .gitignore output to match the template content (adds *.lscache). |
| .vsts-pr.yml | Expands PR path filters to include template_feed so CI runs for template feed changes. |
…rget no longer run for now.
…ine.Orchestrator.RunnableProjects project reference to avoid build collisions.
NikolaMilosavljevic
approved these changes
Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #53752
Related: #54056
Summary
Test Failure
The recent PR that added
.lscacheto the .gitignore file. We have a test that runs against the .gitignore file. This test did not run in the PR because CI didn't run in the PR. This PR addresses the test failure and adds thetemplate_feedfolder as a folder that is monitored for changes so that CI runs appropriately.Build Failure 1 (consistent)
For the second PR, it was causing a build error.
I tried to add
TargetFramework=$(SdkTargetFramework), but that did not seem to fix the issue. Instead, I've just set the target to no longer run since it is not critical for any SDK functionality yet.Build Failure 2 (inconsistent)
There was an inconsistent build failure happening.
Had Copilot take a look. It realized there is a pattern to including projects in the
dotnet.csproj. The recently migrated TemplateEngine project,Microsoft.TemplateEngine.Orchestrator.RunnableProjects, did not follow this pattern. It seemsGlobalPropertiesToRemove="PublishDir"was missing, so that has been added to the project reference.