Skip to content

April11 script sync#1003

Merged
StephenBonikowsky merged 6 commits intodotnet:masterfrom
StephenBonikowsky:April11ScriptSync
Apr 13, 2016
Merged

April11 script sync#1003
StephenBonikowsky merged 6 commits intodotnet:masterfrom
StephenBonikowsky:April11ScriptSync

Conversation

@StephenBonikowsky
Copy link
Member

First part of syncing our build related scripts to corefx.
There are many changes and I found that syncing PR by PR was the best way.
This allows me to test each PR and when some change causes an issue or looks suspect I can skip that PR and do others ones.
All of these corefx PRs built for me and I would like to merge if possible so that tomorrow I can keep going with the remaining PRs and some other outstanding issues.

  • Note: Rebasing removed some parts of some PRs, they are making so many changes that one person's changes one week are removed or modified the next.

SHA:59844e6bf00b6df5b95e795630619140ce149bb6 - Build packages step
SHA:2fc4efcb6c7a977ccc679964586ef3bf0b23311f - Add SkipNativePackageBuild and SkipManagedPackageBuild to disable native or managed package build
* SHA:d46ecb53011b18a0a30cd200390a537402096971 - Consuming new versioning changes
* SHA:e569cb5849c72b12f1ced7a634ea7dfb8b40c181 - Enable running the analyzers from BuildTools during the CoreFx build.
* SHA:36692c3f15467d7f53fe2a506612f155134e754a - Add test runtime project.json support running against desktop
* SHA:4c426808e2c1c1b122d5950a782665d656d2f030 - Add initial support for publishing packages.
* SHA: 0f268ed1079c182d71cdf49cde3f339a01d67863 - Temporarily revert implementation assembly version to match package version
* SHA:25bbfea64828d423becd32e4aa56bd821d93860e - Move dependency validation patterns to Item metadata and add programmatic names.
* Also includes a few additional minor old changes.
* SHA:677ffb86351f93b5017beeddab1ca91821abaf79 - Fix project.json and csproj errors noticed by ericstj
* SHA:c3703d3b151073c41c8d9d57cc4e19c795864577 - Fix ReportGenerator task
@iamjasonp
Copy link
Member

@dotnet-bot test Innerloop OSX Debug Build and Test, test Innerloop OSX Release Build and Test

It looks like the Mac queues hung - so am retesting

@iamjasonp
Copy link
Member

Question only:
Should we copy over https://github.com/dotnet/corefx/pull/7056/files - UpdateDependencies.ps1 as well?

This script updates all the project.json files with the latest CoreFX build version,
and then creates a Pull Request for the change.

Seems like it could be useful for this repo too; otherwise we can just keep it in mind and do a copy over every time we want to use it without committing it to our own repo.

@iamjasonp
Copy link
Member

Question only:
Any need for us to add the AssemblyVersionTransition to our csproj files from PR 7135?

@iamjasonp
Copy link
Member

Question only:
From PR 7420 - publish-packages.cmd and publish-packages.sh required to be copied?

@iamjasonp
Copy link
Member

LGTM. I think we'll need to do a TFS build with these changes too to confirm it doesn't break in TFS in unexpected ways.

The other comments I had aren't necessary for this merge, we can take them later if needed.

@roncain
Copy link
Contributor

roncain commented Apr 13, 2016

LGTM.
I did a fresh build of TFS with this PR in place. It built clean and ToF tests passed.
I recommend we merge what we have asap and react to comments from @iamjasonp post-merge.

@iamjasonp
Copy link
Member

+1. TFS build was successful for me. Please feel free to merge and take the questions post-merge

@iamjasonp
Copy link
Member

Also, the innerloop OSX failure is intermittent when restoring build tools. I'm not concerned about that.

@StephenBonikowsky
Copy link
Member Author

UpdateDependencies.ps1 - Yes but didn't include it with this PR because initially I was focused on syncing the shared files, and I wasn't sure if we wanted to include it until we tried it to see if it works for us.
AssemblyVersionTransition - Not sure, I missed that, will follow up with Stephen Toub.
PR 7420 - Not sure if we will publish packages from our repo.

@zhenlan
Copy link
Member

zhenlan commented Apr 13, 2016

Not sure if we will publish packages from our repo

This should be the goal eventually.

@StephenBonikowsky StephenBonikowsky deleted the April11ScriptSync branch April 15, 2016 18:06
imcarolwang added a commit to imcarolwang/wcf that referenced this pull request Nov 18, 2019
StephenBonikowsky added a commit that referenced this pull request Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants