Update to latest xunit.netcore.extensions#1004
Merged
roncain merged 2 commits intodotnet:masterfrom Apr 13, 2016
Merged
Conversation
Contributor
Author
|
Reviewers: I verified this is the correct version by manually updating our one use of [ConditionalFact] to include multiple conditions. It compiled and was worked successfully. That modified test is not part of this PR. |
Member
|
LGTM |
Contributor
Author
|
I'll wait for @StephenBonikowsky to merge first and retest on top of his changes. |
Member
|
#1003 got merged 😄 test away! |
This update allows us to use multiple conditions in [ConditionalFact] tests. This feature was added to xunit.netcore.extensions with PR dotnet/buildtools#619, and now that the latest package is available, we can use it.
roncain
force-pushed
the
xunit.netcore.extensions
branch
from
a20ba66 to
b0b5ee3
Compare
Contributor
Author
|
Retested after rebasing on #1003. It passed again after updating newest dir.props to express the right version for xunit.netcore.extensions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update allows us to use multiple conditions in
[ConditionalFact] tests.
This feature was added to xunit.netcore.extensions with
PR dotnet/buildtools#619, and now
that the latest package is available, we can use it.