Remove .NET Framework isms by RussKie · Pull Request #1139 · dotnet/winforms

RussKie · 2019-06-18T05:10:32Z

Closes #485

Proposed changes

Fixed a number of xml-docs that referenced ".NET Framework" (i.e. Windows-only .NET Framework) in favour of ".NET framework" (i.e. The .NET framework that we all have starting in .NET 5).
Remove redundant test plumbing
Deprecate Switch.System.Windows.Forms.DoNotSupportSelectAllShortcutInMultilineTextBox
Deprecate Switch.System.Windows.Forms.DoNotLoadLatestRichEditControl and remove RichEdit references prior to version 4.1
Deprecate Switch.System.Windows.Forms.UseLegacyImages
Deprecate Switch.System.Windows.Forms.UseLegacyContextMenuStripSourceControlValue
Deprecate Switch.System.Windows.Forms.DomainUpDown.UseLegacyScrolling
Deprecate Switch.System.Windows.Forms.AllowUpdateChildControlIndexForTabControls
Deprecate Switch.System.Windows.Forms.DontSupportReentrantFilterMessage
Deprecate Switch.System.Windows.Forms.EnableVisualStyleValidation
Remove LocalAppContext and LocalAppContextSwitches as obsolete and redundant.

Customer Impact

Customer who may have relied on these quirks may need to update their apps porting from .NET Fx to .NET Core

Regression?

No

Risk

Likely low

danmoseley · 2019-07-09T22:46:49Z

@RussKie I think you can merge this

dreddy-work · 2019-07-09T22:50:33Z

Are we not removing the word "framework" and just keep .NET? Also, there was a bigger PR #1267 that needs to be merged as well.

RussKie · 2019-07-26T12:24:14Z

What should we do with LocalAppContextSwitches - there are few "legacy" switches

winforms/src/System.Windows.Forms/src/System/Windows/Forms/LocalAppContextSwitches.cs

Lines 11 to 18 in f38a7a1

    
           internal const string DontSupportReentrantFilterMessageSwitchName = @"Switch.System.Windows.Forms.DontSupportReentrantFilterMessage"; 
        
           internal const string DoNotSupportSelectAllShortcutInMultilineTextBoxSwitchName = @"Switch.System.Windows.Forms.DoNotSupportSelectAllShortcutInMultilineTextBox"; 
        
           internal const string DoNotLoadLatestRichEditControlSwitchName = @"Switch.System.Windows.Forms.DoNotLoadLatestRichEditControl"; 
        
           internal const string UseLegacyContextMenuStripSourceControlValueSwitchName = @"Switch.System.Windows.Forms.UseLegacyContextMenuStripSourceControlValue"; 
        
           internal const string DomainUpDownUseLegacyScrollingSwitchName = @"Switch.System.Windows.Forms.DomainUpDown.UseLegacyScrolling"; 
        
           internal const string AllowUpdateChildControlIndexForTabControlsSwitchName = @"Switch.System.Windows.Forms.AllowUpdateChildControlIndexForTabControls"; 
        
           internal const string UseLegacyImagesSwitchName = @"Switch.System.Windows.Forms.UseLegacyImages"; 
        
           internal const string EnableVisualStyleValidationSwitchName = @"Switch.System.Windows.Forms.EnableVisualStyleValidation";

RussKie · 2019-07-29T08:07:26Z

@danmosemsft @dreddy-work @merriemcgaw any thoughts? ^^^

merriemcgaw · 2019-07-29T17:27:43Z

These are quirks so that customers could disable features/fixes done in Framework updates. Our plan was to turn everything on for Core because customers that are porting to Core have to test all of this anyway. If there is no reference to them in code we can remove them. If there is, we should consider whether to remove the reference and the quirk both. Each one is different.

RussKie · 2019-08-01T12:26:47Z

Ready for review.

I have removed a bunch of legacy quirks, please have a look

src/Common/tests/InternalUtilitiesForTests/src/PlatformDetection.cs

Tanya-Solyanik

Looks good.

src/System.Windows.Forms/src/System/Resources/ResXDataNode.cs

src/System.Windows.Forms/src/System/Windows/Forms/RichTextBox.cs

…nMultilineTextBox"

Remove RichEdit references prior to version 4.1

…eControlValue"

…rTabControls"

…age"

zsd4yr · 2019-08-15T19:48:52Z

approved by Steve.

@RussKie please cleanup your last commit message and merge at your leisure.

RussKie · 2019-08-15T20:00:52Z

Thank you.

RussKie · 2019-09-02T19:17:05Z

docs:

The newer RichEdit controls (v4.1+) in specific cases had troubles detecting "friendly named" hyperlinks as the `Text` property was reportig less characters than the rage of the actual hyperlink. Fixes dotnet#1631 Relates to dotnet#1139

RussKie requested review from M-Lipin and dreddy-work June 18, 2019 05:10

RussKie changed the title ~~Remove .NET Framework isms~~ WIP: Remove .NET Framework isms Jun 18, 2019

RussKie assigned RussKie and M-Lipin Jun 20, 2019

RussKie mentioned this pull request Jul 3, 2019

Removing instances of "Framework" and Cleaning unused methods #1267

Merged

danmoseley approved these changes Jul 9, 2019

View reviewed changes

RussKie force-pushed the dev/igveliko/fix_485_remove_NET_Framework_isms branch from bc0003f to 182f9e1 Compare July 26, 2019 12:21

This comment has been minimized.

Sign in to view

RussKie force-pushed the dev/igveliko/fix_485_remove_NET_Framework_isms branch from 182f9e1 to b1a8111 Compare July 26, 2019 13:27

RussKie force-pushed the dev/igveliko/fix_485_remove_NET_Framework_isms branch from b1a8111 to 49d6c7a Compare August 1, 2019 10:57

RussKie changed the title ~~WIP: Remove .NET Framework isms~~ Remove .NET Framework isms Aug 1, 2019

RussKie marked this pull request as ready for review August 1, 2019 12:25

RussKie requested a review from a team as a code owner August 1, 2019 12:25

RussKie added the tell-mode label Aug 1, 2019

ghost added this to the 3.0.0-Preview9 milestone Aug 1, 2019

RussKie force-pushed the dev/igveliko/fix_485_remove_NET_Framework_isms branch from e386fb8 to d03785d Compare August 1, 2019 12:49

merriemcgaw removed the tell-mode label Aug 1, 2019

RussKie added the tell-mode label Aug 1, 2019

Tanya-Solyanik reviewed Aug 2, 2019

View reviewed changes

src/Common/tests/InternalUtilitiesForTests/src/PlatformDetection.cs Outdated Show resolved Hide resolved

Tanya-Solyanik approved these changes Aug 2, 2019

View reviewed changes

src/System.Windows.Forms/src/System/Resources/ResXDataNode.cs Outdated Show resolved Hide resolved

src/System.Windows.Forms/src/System/Windows/Forms/RichTextBox.cs Outdated Show resolved Hide resolved

RussKie added the 📖 documentation: breaking please open a breaking change issue https://github.com/dotnet/docs/issues/new?assignees=gewarren label Aug 2, 2019

RussKie force-pushed the dev/igveliko/fix_485_remove_NET_Framework_isms branch 2 times, most recently from 3fad577 to 83f8feb Compare August 2, 2019 19:40

RussKie added 9 commits August 12, 2019 16:54

Deprecate "Switch.System.Windows.Forms.DoNotSupportSelectAllShortcutI…

fb99a50

…nMultilineTextBox"

Deprecate "Switch.System.Windows.Forms.DoNotLoadLatestRichEditControl"

3f2ca8a

Remove RichEdit references prior to version 4.1

Deprecate "Switch.System.Windows.Forms.UseLegacyImages"

9f332cc

Deprecate "Switch.System.Windows.Forms.UseLegacyContextMenuStripSourc…

bedd955

…eControlValue"

Deprecate "Switch.System.Windows.Forms.DomainUpDown.UseLegacyScrolling"

ae6e4c3

Deprecate "Switch.System.Windows.Forms.AllowUpdateChildControlIndexFo…

963e28f

…rTabControls"

Deprecate "Switch.System.Windows.Forms.DontSupportReentrantFilterMess…

9237073

…age"

Deprecate "Switch.System.Windows.Forms.EnableVisualStyleValidation"

f9e67f9

Remove dead code

f5745ff

RussKie force-pushed the dev/igveliko/fix_485_remove_NET_Framework_isms branch from 0bfb6e1 to f5745ff Compare August 12, 2019 14:04

zsd4yr approved these changes Aug 12, 2019

View reviewed changes

RussKie added 🚫 * NO-MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) and removed 🚫 * NO-MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) tell-mode labels Aug 13, 2019

RussKie assigned zsd4yr and unassigned RussKie and M-Lipin Aug 15, 2019

RussKie merged commit d989476 into master Aug 15, 2019

RussKie deleted the dev/igveliko/fix_485_remove_NET_Framework_isms branch August 15, 2019 20:00

RussKie added the 📖 documentation: breaking please open a breaking change issue https://github.com/dotnet/docs/issues/new?assignees=gewarren label Aug 15, 2019

RussKie mentioned this pull request Sep 3, 2019

fix: RichTextBox LinkClicked event for "friendly named" hyperlinks #1745

Merged

ghost locked as resolved and limited conversation to collaborators Feb 6, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove .NET Framework isms#1139

Remove .NET Framework isms#1139
RussKie merged 10 commits intomasterfrom
dev/igveliko/fix_485_remove_NET_Framework_isms

RussKie commented Jun 18, 2019 •

edited

Loading

Uh oh!

danmoseley commented Jul 9, 2019

Uh oh!

dreddy-work commented Jul 9, 2019 •

edited

Loading

Uh oh!

RussKie commented Jul 26, 2019

Uh oh!

This comment has been minimized.

RussKie commented Jul 29, 2019

Uh oh!

merriemcgaw commented Jul 29, 2019

Uh oh!

RussKie commented Aug 1, 2019

Uh oh!

Uh oh!

Tanya-Solyanik left a comment

Uh oh!

Uh oh!

Uh oh!

zsd4yr commented Aug 15, 2019

Uh oh!

RussKie commented Aug 15, 2019

Uh oh!

RussKie commented Sep 2, 2019 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

RussKie commented Jun 18, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes

Customer Impact

Regression?

Risk

Uh oh!

danmoseley commented Jul 9, 2019

Uh oh!

dreddy-work commented Jul 9, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RussKie commented Jul 26, 2019

Uh oh!

This comment has been minimized.

RussKie commented Jul 29, 2019

Uh oh!

merriemcgaw commented Jul 29, 2019

Uh oh!

RussKie commented Aug 1, 2019

Uh oh!

Uh oh!

Tanya-Solyanik left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

zsd4yr commented Aug 15, 2019

Uh oh!

RussKie commented Aug 15, 2019

Uh oh!

RussKie commented Sep 2, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

RussKie commented Jun 18, 2019 •

edited

Loading

dreddy-work commented Jul 9, 2019 •

edited

Loading

RussKie commented Sep 2, 2019 •

edited

Loading