Removing instances of "Framework" and Cleaning unused methods#1267
Merged
Removing instances of "Framework" and Cleaning unused methods#1267
Conversation
merriemcgaw
reviewed
Jul 2, 2019
Member
merriemcgaw
left a comment
merriemcgaw
left a comment
There was a problem hiding this comment.
Shouldn't this be in at least 2 PRs. One method cleanup/removal of dead code. And the main one being the removal of "Framework" and the RESX schema content?
Contributor
hughbe
suggested changes
Jul 3, 2019
| @@ -3158,14 +3158,14 @@ just-in-time (JIT) debugging instead of this dialog box. | |||
| <value>&Quit</value> | |||
| </data> | |||
| <data name="ExDlgSecurityContinueErrorText" xml:space="preserve"> | |||
Contributor
There was a problem hiding this comment.
This seems like it should be removed
Member
Author
There was a problem hiding this comment.
Are you saying this is not used anymore? I have not checked its usage yet. If this is indeed need to be removed, Lets do it in a separate PR. Do not want to block this PR on this.
Member
Author
|
Regarding separate PR, This is all cleanup. low risk and unused code. If you do not have a strong opinion on splitting this, i like to merge this in a single PR. @RussKie |
dreddy-work
added
the
code cleanup
RussKie
approved these changes
Jul 10, 2019
dreddy-work
changed the title
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleaning DpiHelper class methods that are not used anymore.
Removing the "Framework" instances.
Cleaning comments and updating resx templates.
Contributes to #485