Merged
Conversation
The initial decision to split types previously located in System.Design led to a number of problems including cyclic dependencies. The percieved benefits of smaller assembly sizes has not realised as both assemblies (Design and Design.Editors) would often need to be references together.
Contributor
Author
|
/cc: @hughbe @kpreisser @gpetrou @M-Lipin @vladimir-krestov FYI |
Codecov Report
@@ Coverage Diff @@
## master #2781 +/- ##
============================================
Coverage ? 31.82704%
============================================
Files ? 832
Lines ? 255550
Branches ? 36661
============================================
Hits ? 81334
Misses ? 169329
Partials ? 4887
|
AdamYoblick
approved these changes
Jan 29, 2020
RussKie
added a commit
to RussKie/winforms
that referenced
this pull request
Feb 28, 2020
As part of consolidation initiative (refer to dotnet#2781) we have merged System.Windows.Forms.Design.Editors.dll into System.Windows.Forms.Design.dll. However doing so we broke roll-forward upgrades for any app depending on types delcared in System.Windows.Forms.Design.Editors.dll. Create a facade assembly that forwards types from original assembly. Resolves dotnet#2921.
RussKie
added a commit
that referenced
this pull request
Mar 3, 2020
As part of consolidation initiative (refer to #2781) we have merged System.Windows.Forms.Design.Editors.dll into System.Windows.Forms.Design.dll. However doing so we broke roll-forward upgrades for any app depending on types delcared in System.Windows.Forms.Design.Editors.dll. Create a facade assembly that forwards types from original assembly. Resolves #2921.
M-Lipin
pushed a commit
to M-Lipin/winforms
that referenced
this pull request
Mar 23, 2020
As part of consolidation initiative (refer to dotnet#2781) we have merged System.Windows.Forms.Design.Editors.dll into System.Windows.Forms.Design.dll. However doing so we broke roll-forward upgrades for any app depending on types delcared in System.Windows.Forms.Design.Editors.dll. Create a facade assembly that forwards types from original assembly. Resolves dotnet#2921.
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
The perceived benefits of smaller assembly sizes has not realised as both assemblies (Design and Design.Editors) would often need to be references together.
Customer Impact
Customers who chose to reference System.Windows.Forms.Design.Editors.dll will need to update reference to System.Windows.Forms.Design.dllCustomers will be broken without type forwardingRegression?
Risk
Microsoft Reviewers: Open in CodeFlow