Fixing the incorrect ScreenReader blue rectangle for a new character when typing (Text pattern area)#3969
Merged
RussKie merged 1 commit intodotnet:masterfrom Oct 12, 2020
Conversation
vladimir-krestov
added
waiting-for-testing
Contributor
|
We had a discussion and decided this doesn't meet the Bar. |
RussKie
added
waiting-author-feedback
ghost
removed
the
waiting-author-feedback
vladimir-krestov
force-pushed
the
Issue_3897_FixingNarratorRectange_for_TypedCharacters
branch
from
fa1d076 to
7a2f25c
Compare
Codecov Report
@@ Coverage Diff @@
## master #3969 +/- ##
====================================================
- Coverage 67.65118% 36.48485% -31.16633%
====================================================
Files 1418 934 -484
Lines 505901 250123 -255778
Branches 41060 36764 -4296
====================================================
- Hits 342248 91257 -250991
+ Misses 157693 153633 -4060
+ Partials 5960 5233 -727
Flags with carried forward coverage won't be shown. Click here to find out more. |
RussKie
previously approved these changes
Sep 23, 2020
vladimir-krestov
removed
the
waiting-for-testing
Contributor
Author
|
Text pattern is not implemented for master branch so this fix is blocked because it is based on Text patter implementation. |
vladimir-krestov
added
the
waiting-review
Contributor
Author
|
Testers approved these changes ✔️ |
vladimir-krestov
force-pushed
the
Issue_3897_FixingNarratorRectange_for_TypedCharacters
branch
from
7a2f25c to
3fe64d8
Compare
…when typing (Text pattern area) Fixes dotnet#3897
vladimir-krestov
force-pushed
the
Issue_3897_FixingNarratorRectange_for_TypedCharacters
branch
from
3fe64d8 to
2be0418
Compare
RussKie
approved these changes
Oct 12, 2020
RussKie
removed
the
waiting-review
vladimir-krestov
deleted the
Issue_3897_FixingNarratorRectange_for_TypedCharacters
branch
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3897
Proposed changes
Text_TextChangedEventto Narrator shows the correct blue rectangle when typing new characters in Edit controls (should work as in Win32 RichTextBox)Customer Impact
Regression?
Risk
Screenshots
Before
After
Test methodology
Accessibility testing
Test environment(s)
Microsoft Reviewers: Open in CodeFlow