Fix dlls not generated in native directory#5974
Merged
singhashish-wpf merged 2 commits intodotnet:mainfrom Jan 21, 2022
singhashish-wpf:pnative
Merged
Fix dlls not generated in native directory#5974singhashish-wpf merged 2 commits intodotnet:mainfrom singhashish-wpf:pnative
singhashish-wpf merged 2 commits intodotnet:mainfrom
singhashish-wpf:pnative
Conversation
ghost
added
the
ghost
requested review from
vishalmsft
approved these changes
Jan 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes # PR Failing Test
Main PR
dotnet/installer#13073
Description
PresentationNative and some more native dls weren't getting created in the native folder, instead were going inside the lib folder.
Customer Impact
Some dlls won't be created in their respective locations.
Regression
This was a regression of the PR #5901
Testing
Local build, CI
Risk
None